Notify orderpool cleanup without IPC #327
Merged
+71
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
requested review from
dvush,
ZanCorDX and
liamaharon
as code owners
Benchmark results for
|
| Date (UTC) | 2025-01-03T15:03:54+00:00 |
| Commit | d4b1efcca69e9e6af837347123fda9267ec69ed3 |
| Base SHA | 39ac5f760f8f0fd187f224de60b15121188338cb |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| gather_nodes_clone | 10.02% | Performance has degraded. |
| MEV-Boost SubmitBlock serialization/JSON encoding | -37.79% | Performance has improved. |
ZanCorDX
approved these changes
Jan 3, 2025
This was referenced Jan 3, 2025
Merged
dvush
reviewed
Jan 14, 2025
| let state = match provider_factory.latest() { | ||
| Ok(state) => state, | ||
| Err(err) => { | ||
| error!("Failed to get latest state: {}", err); |
There was a problem hiding this comment.
please, do logs like this
error!(?err, "Message")
This is how its done in the rest of the codebase and it makes the errors appear as a field in the json logs instead of the message.
ferranbt
added a commit
that referenced
this pull request
Jan 16, 2025
## 📝 Summary Bug introduced in #327. Rbuilder would not stop with `Ctrl-C` because it would be waiting for `spawn_clean_orderpool_job` to finish. But, `spawn_clean_orderpool_job` would not handle the cancellation token. ## 💡 Motivation and Context <!--- (Optional) Why is this change required? What problem does it solve? Remove this section if not applicable. --> --- ## ✅ I have completed the following steps: * [x] Run `make lint` * [x] Run `make test` * [x] Added tests (if applicable) --------- Co-authored-by: Daniel Xifra <mandinga@gmail.com> Co-authored-by: liamaharon <liam.aharon@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #318. This PR uses the block building flow to notify the order pool to clean old transactions instead of using the IPC path of the EL node.
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test