Stop spawn_clean_orderpool_job on shutdown #349
Conversation
Benchmark results for
|
| Date (UTC) | 2025-01-15T21:21:19+00:00 |
| Commit | d3a2fca73b595d67ebbf9167396ebe29b532cf96 |
| Base SHA | c1c5595d5bc08529375a38c50a2fc3f74e285e58 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| gather_nodes_empty_account | -3.78% | Performance has improved. |
| hashing_3000_elements | 5.07% | Performance has degraded. |
| }; | ||
| loop { | ||
| tokio::select! { | ||
| Some(header) = header_receiver.recv() => { |
There was a problem hiding this comment.
What happens is header_receiver.recv() gives None?
There was a problem hiding this comment.
Isn't this equivalent to what we had before? If it is not Some it will not perform that check and wait for the next iteration?
There was a problem hiding this comment.
I haven't tried it. Claude says None will not match and will not stop the loop so it may not behave exactly as before.
You get the exact behavior as before (stop con channel end) if you match header_res = header_receiver.recv() without the "Some" and then check match for Some (current code)/None (end)
| @@ -334,33 +334,41 @@ where | |||
| let handle = tokio::spawn(async move { | |||
There was a problem hiding this comment.
Usually this jobs need to be spawned as blocking and not as async tasks and its time consuming and blocks executor.
There was a problem hiding this comment.
Its probably fine here as this job happens between slots.
Sometimes, the Cargo.lock will differ between `BASE_SHA` and `HEAD_SHA`. This can cause the final checkout to `HEAD_SHA` to fail. This PR resolves that, by resetting any changes prior to the final checkout.
sukoneck
force-pushed
the
fix/cancel-orderpool-cleaner
branch
from
e27928c to
d3a2fca
Compare
📝 Summary
Bug introduced in #327. Rbuilder would not stop with
Ctrl-Cbecause it would be waiting forspawn_clean_orderpool_jobto finish. But,spawn_clean_orderpool_jobwould not handle the cancellation token.💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test