Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing the dependency footprint #94

Closed
1 of 3 tasks
danielwhite opened this issue Dec 1, 2017 · 3 comments
Closed
1 of 3 tasks

Reducing the dependency footprint #94

danielwhite opened this issue Dec 1, 2017 · 3 comments

Comments

@danielwhite
Copy link
Contributor

danielwhite commented Dec 1, 2017

Currently I've been building a prototype to use this to provide an SMTP adapter to an internal system and I'm really loving the changes to provide this as a library.

The problem I'm facing with gaining more acceptance are the dependencies that are unrelated to the primary problem.

Is there is any appetite for contributions to reduce this footprint?

Specifically:

  • MySQL: provide a compatible interface or use a separate repository (like maildir-processor)
  • Redis: provide a compatible interface or use a separate repository (like maildir-processor)
  • logrus: provide a compatible interface to logrus, but only directly reference in cmd/

From what I can tell, cmd/guerrillad is excluded from dependency resolution (at least by golang/dep), so it definitely can continue to import the above packages to provide a fully featured default server.

@flashmob
Copy link
Owner

Hello @danielwhite

Sorry for the long break, but are you still around? If so, could you have a few minutes to take a look at this PR and tell me if that's what you meant?

#114

@danielwhite
Copy link
Contributor Author

Hi @flashmob, somehow got lost along the way. This looks pretty close. Thanks!

@flashmob
Copy link
Owner

flashmob commented Jun 18, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants