Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis: provide a generic interface, import redigo optionally from main #114

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

flashmob
Copy link
Owner

issue #94

A new interface has been created for Redis (redis_generic.go) complete with a mock implementation.
A driver is in a different package, in backends/storage/redigo/driver.go
This driver is enabled from serve.go found in the cmd/guerrillad dir, similar to the way the mysql driver is enabled

@flashmob flashmob mentioned this pull request Jun 10, 2018
3 tasks
@flashmob flashmob changed the title Redis: provide a generic interface, import redigo optionally main Redis: provide a generic interface, import redigo optionally from main Jun 10, 2018
@jasonfriedland
Copy link

Hi, what's the timeline for this being merged?

I was about to submit a change to update the redigo import path to fix internal/ package import issues from another package which has the same dependency but is updated to use the new path.

This change will fix this :-)

@flashmob flashmob merged commit 1c628e5 into master Aug 22, 2018
@phires phires deleted the redis-dependency branch June 4, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants