-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nightly additions #262
base: master
Are you sure you want to change the base?
nightly additions #262
Conversation
We'll not have this merged to the master branch. On master we shall only push stable versions like upstream. If at all, nightly would live in beta, however, due to version pinning, we'll get daily merge requests. Therefore unless we also automerge them into the beta channel, I'm not willing to take on nightly builds for now. |
@SISheogorath Hey, that's fine. I am mostly attempting to use the build infrastructure here to build a nightly for myself. I haven't done flatpaks before so am not sure what goes into maintaining one, further so a nightly. Though automerges to a beta branch does sound like minimal maintenance. Do you think there would be much involvement with that approach? |
Started test build 85321 |
We had some talking about this here: #245 If we setup automerging in a functional way, yes, then we could go for nightly, but for now, I haven't done that and I would prefer manual promotion on master, so I have to check if flathub.json is interpreted from the default branch or from all branches. |
Merging into beta can be done automatically (while leaving master alone). You will want to keep the branches in sync though when changing the manifest. |
the flathub.json in beta corresponds to only beta, however, the flathub hosted f-e-d-c can only update the default branch set in github (currently master). If you want to update beta and master (on their own schedule), in beta you can add the flathub.json, and in master you can add a scheduled f-e-d-c workflow. https://github.com/flathub/com.github.wwmm.easyeffects/blob/master/.github/workflows/update-beta.yml |
Build 85321 failed |
Started test build 85328 |
Build 85328 failed |
Started test build 85377 |
Build 85377 successful
|
I have tried the packaged nightly flatpack - works a treat, labs with threads and all 👍 This is enough for my purposes. Though I am willing to look into anything further to have it delivered to a beta branch, to have these automatic. I have added the workflow script suggested above for betas. @SISheogorath Is there will to have this delivered, autobuilt & maintained in a beta branch? Anything I can help with? |
Started test build 85410 |
Build 85410 successful
|
As mentioned above, for automerge to work you need to make a PR for just the workflow to master, and target the rest of the changes to beta. |
Started test build 88379 |
Build 88379 successful
|
Started test build 89021 |
Build 89021 successful
|
So I went ahead and talked with some people. Thankfully I was pointed to this discussion: flathub/flathub#2975 (comment) I think the best solution for nightlies is to have them upstream foe now and not getting them in here. I would recommend to help working on the upstream integration: element-hq/element-desktop#293 Unless I hear something else any time soon, I'll close this PR and the efforts around it by the end of today. |
No description provided.