Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding workflow for beta packages #264

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding workflow for beta packages #264

wants to merge 2 commits into from

Conversation

h7io
Copy link

@h7io h7io commented Apr 8, 2022

Initial work for enabling nightly packaging via the beta branch. Would still need 34b8421 delivered to the beta branch after it is created, for which I will be able to create a PR.

@h7io h7io mentioned this pull request Apr 8, 2022
GIT_COMMITTER_NAME: Flatpak External Data Checker
GIT_AUTHOR_EMAIL: ${{ github.actor }}@users.noreply.github.com
GIT_COMMITTER_EMAIL: ${{ github.actor }}@users.noreply.github.com
EMAIL: ${{ github.actor }}@users.noreply.github.com
Copy link
Contributor

@vchernin vchernin Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, note you might want to change the email to something generic, otherwise the bot- created commits might be under your name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. perhaps the GitHub actions bot email will work? https://github.saobby.my.eu.orgmunity/t/github-actions-bot-email-address/17204/6

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks. I have changed the email-related environment variables. I don't know what the EMAIL one is meant for, but I changed it too.

@h7io h7io marked this pull request as draft April 8, 2022 16:45
@h7io h7io marked this pull request as ready for review April 8, 2022 16:53
@flathubbot
Copy link
Contributor

Started test build 85461

@flathubbot
Copy link
Contributor

Build 85461 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/83305/im.riot.Riot.flatpakref

@h7io
Copy link
Author

h7io commented Apr 13, 2022

@SISheogorath Hey,
so is there any will to go ahead with this?

@SISheogorath
Copy link
Collaborator

Yes, there is, but I will need to set aside some time, to get things sorted, including properly updating the beta branch and getting some opinions on nightly builds in beta or as a separate app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants