-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding workflow for beta packages #264
base: master
Are you sure you want to change the base?
Conversation
.github/workflows/update-nightly.yml
Outdated
GIT_COMMITTER_NAME: Flatpak External Data Checker | ||
GIT_AUTHOR_EMAIL: ${{ github.actor }}@users.noreply.github.com | ||
GIT_COMMITTER_EMAIL: ${{ github.actor }}@users.noreply.github.com | ||
EMAIL: ${{ github.actor }}@users.noreply.github.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, note you might want to change the email to something generic, otherwise the bot- created commits might be under your name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.g. perhaps the GitHub actions bot email will work? https://github.saobby.my.eu.orgmunity/t/github-actions-bot-email-address/17204/6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks. I have changed the email-related environment variables. I don't know what the EMAIL
one is meant for, but I changed it too.
Started test build 85461 |
Build 85461 successful
|
@SISheogorath Hey, |
Yes, there is, but I will need to set aside some time, to get things sorted, including properly updating the beta branch and getting some opinions on nightly builds in beta or as a separate app. |
Initial work for enabling nightly packaging via the
beta
branch. Would still need 34b8421 delivered to thebeta
branch after it is created, for which I will be able to create a PR.