Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert build from source #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fabiojb
Copy link
Contributor

@fabiojb fabiojb commented Jan 11, 2025

Revert changes made on PR #85 that broke flathubbot updates (see #102 and #103)

@flathubbot
Copy link
Contributor

Started test build 173571

@flathubbot
Copy link
Contributor

Build 173571 failed

Revert changes made on PR flathub#85 that broke flathubbot updates (flathub#102 and flathub#103)
@fabiojb fabiojb force-pushed the revert-build-from-source branch from ed4a243 to cb9ccd1 Compare January 11, 2025 02:01
@flathubbot
Copy link
Contributor

Started test build 173575

@flathubbot
Copy link
Contributor

Build 173575 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/156704/rest.insomnia.Insomnia.flatpakref

@hexchain
Copy link
Collaborator

I'm all for a simpler update process but how do we support aarch64 when the upstream doesn't provide a binary?

@fabiojb
Copy link
Contributor Author

fabiojb commented Jan 20, 2025

@hexchain Building from source would require a manual update of sources.json on every Insomnia update where dependencies change.

I tried to create a flatpak build step to generate sources.json automatically, and then proceed building from source, but with no success. It doesn't seem that flatpak-builder-tools is intended to be used during flatpak builds.

So my conclusion is that there is no way to support aarch64 builds without upstream support, unless there is someone available to manually update sources.json on every new release.

Maybe opening an issue upstream and request aarch64 binaries for new releases could be a more viable way of solving this.

@fabiojb
Copy link
Contributor Author

fabiojb commented Jan 20, 2025

Also, maybe using Github Actions to create an updated version of sources.json, triggered by upstream new releases, and using that to build from source could be another way

@hexchain
Copy link
Collaborator

I tried to create a flatpak build step to generate sources.json automatically, and then proceed building from source, but with no success. It doesn't seem that flatpak-builder-tools is intended to be used during flatpak builds.

Indeed, that tool is not supposed to be run inside flatpak builds (see here).

A bigger problem is that tool cannot handle some corner cases in this project (e.g. dependency on git repo in package.json), which requires even more manual operation (see the scripts directory for an attempt at making this process less painful). The current workaround is to add the git repo as a source, build it, and replace its path in the relevant package.json. However, there is another git repo dependency (in versions >10.1.0) that I haven't figured out how to correctly override since it is a transitive dependency. I'm not knowledgeable enough with the JS ecosystem so I'd appreciate some helps.

Meanwhile I'll open an issue in the upstream repo to ask for aarch64 binary support.

@hexchain
Copy link
Collaborator

Kong/insomnia#8306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants