-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build from source and upgrade to 9.2.0 #85
Conversation
Started test build 125643 |
Build 125643 failed |
Started test build 125658 |
Build 125658 successful
|
Started test build 125660 |
Build 125660 failed |
Started test build 125668 |
Build 125668 failed |
Started test build 125670 |
Build 125670 failed |
Started test build 125677 |
Build 125677 successful
|
bot, build |
Queued test build for rest.insomnia.Insomnia. |
Started test build 129687 |
Build 129687 successful
|
@barthalion Sorry for the direct ping. May I have a review please? |
Revert changes made on PR flathub#85 that broke flathubbot updates (flathub#102 and flathub#103)
Revert changes made on PR flathub#85 that broke flathubbot updates (flathub#102 and flathub#103)
This PR updates Insomnia to 9.2.0 and builds it from source code. This also makes it possible to support aarch64.
Some notes:
flatpak-node-generator
has some issues:playwright
. This is skipped here (by modifying f-n-g source code), as they are not required for building.installVersion
of node-gyp to always be 9, which is incorrect - this is manually tweaked ingenerated-sources.json
. Without this step,node-libcurl
will be incorrectly built against node instead of electron, and the final program will fail with a symbol error at run time.electron-builder
does not generate desktop and icon files unless it is making a (deb/rpm/snap/flatpak/...) package. This behavior is (ab)used to generate them.Open question:
com.insomnia.app
to match upstream? https://github.com/Kong/insomnia/blob/1b5723a01b8bf18b0fd0e470a342246d5bb2617d/packages/insomnia/electron-builder.config.js#L12