Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build from source and upgrade to 9.2.0 #85

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Build from source and upgrade to 9.2.0 #85

merged 3 commits into from
Jul 1, 2024

Conversation

hexchain
Copy link
Collaborator

@hexchain hexchain commented Jun 3, 2024

This PR updates Insomnia to 9.2.0 and builds it from source code. This also makes it possible to support aarch64.

Some notes:

  • See https://docs.flatpak.org/en/latest/electron.html for Electron packaging information.
  • flatpak-node-generator has some issues:
    • It misses some packages, see node: Fix path-based local package detection flatpak/flatpak-builder-tools#412.
    • It cannot handle browser downloads for newer versions of playwright. This is skipped here (by modifying f-n-g source code), as they are not required for building.
    • It assumes the installVersion of node-gyp to always be 9, which is incorrect - this is manually tweaked in generated-sources.json. Without this step, node-libcurl will be incorrectly built against node instead of electron, and the final program will fail with a symbol error at run time.
  • electron-builder does not generate desktop and icon files unless it is making a (deb/rpm/snap/flatpak/...) package. This behavior is (ab)used to generate them.

Open question:

@flathubbot
Copy link
Contributor

Started test build 125643

@flathubbot
Copy link
Contributor

Build 125643 failed

@flathubbot
Copy link
Contributor

Started test build 125658

@flathubbot
Copy link
Contributor

Build 125658 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/108618/rest.insomnia.Insomnia.flatpakref

@flathubbot
Copy link
Contributor

Started test build 125660

@flathubbot
Copy link
Contributor

Build 125660 failed

@flathubbot
Copy link
Contributor

Started test build 125668

@flathubbot
Copy link
Contributor

Build 125668 failed

@flathubbot
Copy link
Contributor

Started test build 125670

@flathubbot
Copy link
Contributor

Build 125670 failed

@flathubbot
Copy link
Contributor

Started test build 125677

@flathubbot
Copy link
Contributor

Build 125677 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/108637/rest.insomnia.Insomnia.flatpakref

@hexchain
Copy link
Collaborator Author

bot, build

@flathubbot
Copy link
Contributor

Queued test build for rest.insomnia.Insomnia.

@flathubbot
Copy link
Contributor

Started test build 129687

@flathubbot
Copy link
Contributor

Build 129687 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/112669/rest.insomnia.Insomnia.flatpakref

@hexchain
Copy link
Collaborator Author

@barthalion Sorry for the direct ping. May I have a review please?

@barthalion barthalion merged commit 60f2af1 into flathub:master Jul 1, 2024
1 check passed
fabiojb added a commit to fabiojb/rest.insomnia.Insomnia that referenced this pull request Jan 11, 2025
Revert changes made on PR flathub#85 that broke flathubbot updates (flathub#102 and flathub#103)
fabiojb added a commit to fabiojb/rest.insomnia.Insomnia that referenced this pull request Jan 11, 2025
Revert changes made on PR flathub#85 that broke flathubbot updates (flathub#102 and flathub#103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants