node: Fix path-based local package detection #412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Please correct me if I'm wrong)
The conditions here, if I understand correctly, are to detect whether a package is from a local source, with these two clues:
node_modules
, andpackage.json
The first one, however, has two issues:
Path.parents
yieldsPosixPath
objects, not strings, so the test'node_modules' in ...
never succeeds.Path.parents
yields all logical ancestors of a path (see https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.parents), which is probably not what we want here.This change fixes these issues.
I tested this by running
flatpak-node-generator -r npm package-lock.json
under Insomnia source tree.supports-color@8.1.0
).