Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Export project to Gist #101

Closed
wants to merge 1 commit into from
Closed

[WIP] Export project to Gist #101

wants to merge 1 commit into from

Conversation

magland
Copy link
Collaborator

@magland magland commented Jun 27, 2024

Adds functionality for saving a project to Gist. This includes #97 content, so that should get merged first.

To try it out, click on "Export" and then there's a button "Export to GitHub Gist". It will walk you through the steps and provide instructions on providing an access token with proper scope.

In a separate PR we can figure out what to do about updating an existing gist.

To summarize:

  • Export
  • Export to GitHub Gist
  • Read instructions on getting the PAT
  • Enter the PAT
  • Click "Export to GitHub Gist"
  • Retrieve the url to the gist AND the shareable SP url that loads the gist

Add functionality to export to GitHub Gist
@magland magland requested review from WardBrian and jsoules June 27, 2024 20:19
@magland
Copy link
Collaborator Author

magland commented Jun 27, 2024

As discussed previously, I think this PAT method is the best way forward for saving gists... rather than making a GH app and using oauth. If we allow saving to GH repo in the future, we'll want to make a proper GH app.

@magland magland changed the title Export project to Gist [WIP] Export project to Gist Jun 28, 2024
@magland
Copy link
Collaborator Author

magland commented Jun 28, 2024

I think there should be an distinction between "export" and "save". Export to a zip, save to a gist. So I'm going to make this two separate buttons on the left panel and we'll see how this looks.

@WardBrian
Copy link
Collaborator

I think there should be an distinction between "export" and "save". Export to a zip, save to a gist. So I'm going to make this two separate buttons on the left panel and we'll see how this looks.

I think I agree, but I would personally swap the names, with save meaning to the local file system, and export meaning to another service (gist)

@magland magland changed the base branch from main to load-from-gist June 29, 2024 18:29
@magland magland changed the base branch from load-from-gist to main June 29, 2024 18:29
@magland magland mentioned this pull request Jun 29, 2024
@magland
Copy link
Collaborator Author

magland commented Jun 29, 2024

Replaced by #114

@magland magland closed this Jun 29, 2024
@WardBrian WardBrian deleted the save-to-gist-2 branch July 8, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants