save project as gist #114
save project as gist #114
Conversation
| For security reasons, your token will not be saved in this | ||
| application, so you may want to store it securely in a text file | ||
| for future use. |
There was a problem hiding this comment.
I thought we had decided local storage was probably fine for this?
There was a problem hiding this comment.
If it's okay, let's make that a future feature. I want to think through security implications more carefully and how to present this to the user. I think saving in browser should be opt-in only.
| o: { defaultDescription: string; personalAccessToken: string }, | ||
| ) => { | ||
| const { defaultDescription, personalAccessToken } = o; | ||
| const description = prompt( |
There was a problem hiding this comment.
Oh also -- this prompt is redundant with the title box already on the save page, right?
I guess it's nice as an "are you sure"?
There was a problem hiding this comment.
This was intentional. When saving to a gist it's important to specify an appropriate title/description, and I often find myself forgetting to do this, even when the option is there in the table, and so this is a very helpful opportunity.
|
Unless you want to discuss the storing PAT to browser further, this might be ready to go. |
| for (const key in files) { | ||
| // gists do not support empty files or whitespace-only files | ||
| if (files[key].trim() === "") { | ||
| console.warn(`File ${key} is empty or whitespace-only. Not saving.`); |
There was a problem hiding this comment.
We'll have to think in the future about whether we need to warn this, since in a data.py/r analysis.py/r world we will expect the presence of empty files. (Fine for now.)
| @@ -0,0 +1,213 @@ | |||
| import { FunctionComponent, useCallback, useContext, useState } from "react"; | |||
There was a problem hiding this comment.
Just noting that this file is getting a little chunky--might consider splitting into separate files for the major components at some point.
|
Changes look good. I think we're ready to merge if @WardBrian is okay with the language. |
Replaces #101 because needed to rebase on the prettier formatted main branch.
Renamed import / export to "Load project" / "Save project". Try it out and see how it feels.