Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't modify original file #61

Closed
GeorgesStavracas opened this issue Nov 23, 2021 · 0 comments · Fixed by #62
Closed

Don't modify original file #61

GeorgesStavracas opened this issue Nov 23, 2021 · 0 comments · Fixed by #62

Comments

@GeorgesStavracas
Copy link
Member

Recently I've been looking into publishing OBS Studio into Flathub directly, and I noticed that the Flatpak builds were generating version numbers with the -modified suffix. OBS generates these version numbers by running git describe --dirty="-modified".

Turns out, this action modifies the original Flatpak manifest file regardless of any actual changes. I think it's probably better to save the modified Flatpak manifest in a separate file, and build from that, instead of modifying the original directly.
GeorgesStavracas added a commit to GeorgesStavracas/flatpak-github-actions that referenced this issue Nov 23, 2021
@GeorgesStavracas
Don't modify original Flatpak manifest
9026619 
Fixes flatpak#61
@GeorgesStavracas GeorgesStavracas mentioned this issue Nov 23, 2021
Merged
GeorgesStavracas added a commit to GeorgesStavracas/flatpak-github-actions that referenced this issue Nov 23, 2021
@GeorgesStavracas
Don't modify original Flatpak manifest
b27424d 
Fixes flatpak#61
GeorgesStavracas added a commit to GeorgesStavracas/flatpak-github-actions that referenced this issue Nov 23, 2021
@GeorgesStavracas
Don't modify original Flatpak manifest
3163ab4 
Store the modified manifest in another JSON or YML file in
the same folder of the original file, but prefixed with
'flatpak-github-action-modified-'.

Fixes flatpak#61
bilelmoussaoui pushed a commit that referenced this issue Nov 23, 2021
@GeorgesStavracas @bilelmoussaoui
Don't modify original Flatpak manifest
1540a90 
Store the modified manifest in another JSON or YML file in
the same folder of the original file, but prefixed with
'flatpak-github-action-modified-'.

Fixes #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't modify original Flatpak manifest GeorgesStavracas/flatpak-github-actions
1 participant
@GeorgesStavracas