Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't modify original Flatpak manifest #62

Merged

Conversation

GeorgesStavracas
Copy link
Member

@GeorgesStavracas GeorgesStavracas commented Nov 23, 2021

Store the modified manifest in another JSON or YML file in the same folder of the original file, but prefixed with flatpak-github-action-modified-.

Fixes #61

@bilelmoussaoui
Copy link
Member

The tests seems to be working fine, can you try it with obs now and see? just point the action to your flatpak-github-actions fork

Store the modified manifest in another JSON or YML file in
the same folder of the original file, but prefixed with
'flatpak-github-action-modified-'.

Fixes flatpak#61
@GeorgesStavracas GeorgesStavracas marked this pull request as ready for review November 23, 2021 14:33
@GeorgesStavracas
Copy link
Member Author

You can verify here that this works: https://github.com/GeorgesStavracas/obs-studio/runs/4300417030

@bilelmoussaoui bilelmoussaoui merged commit 1540a90 into flatpak:master Nov 23, 2021
@bilelmoussaoui
Copy link
Member

Thanks !

@GeorgesStavracas GeorgesStavracas deleted the gbsneto/dont-touch-this branch November 23, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't modify original file
2 participants