Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add safe-guards to allow octree headers only if octomap enabled #136

Merged
merged 1 commit into from
Jun 26, 2016

Commits on Jun 24, 2016

  1. add safe-guards to allow octree headers only if octomap enabled

    octomap is no header-only dependency and there is a hard-coded
    value in the internal config.h header that specifies whether it
    is available or not. This value influences the behavior of
    fcl headers (include/fcl/traversal/traversal_node_setup.h) and
    it influences which methods are available in the library
    (src/broadphase/broadphase_dynamic_AABB_tree.cpp)
    Using these interfaces even though fcl was configured without
    octomap invites trouble and should be prevented.
    
    Problems arise if fcl is not compiled with octomap but some version
    of octomap is available at compile time of a dependent project.
    Basically this is the case with libfcl in ubuntu xenial
    (it was compiled without octomap support) and ros kinetic's octomap 1.8.
    I expected to find errors on fcl not being configured with octomap
    but instead only got compile issues because of interface changes.
    v4hn committed Jun 24, 2016
    Configuration menu
    Copy the full SHA
    657795c View commit details
    Browse the repository at this point in the history