Removing unused/unusable code #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanCurtis-TRI
commented
Feb 4, 2020
There was a problem hiding this comment.
+@sherm1 for both review, please.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @sherm1)
In a related issue (421) some code in the hierarchy tree was found to be impossible. Specifically, it could not reasonably be expected to compile. In fact, it couldn't. But it didn't cause problems because the functions weren't actually exercised. Because the functions were templated, the compiler just ignored them. Given that no one is calling them, they clearly serve no purpose. So, they are being cut out rather than fixed.
SeanCurtis-TRI
force-pushed
the
PR_excise_unused_code_issue_421
branch
from
a2233a8
to
dee5977
Compare
sherm1
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a related issue (421) some code in the hierarchy tree was found to be impossible. Specifically, it could not reasonably be expected to compile. In fact, it couldn't. But it didn't cause problems because the functions weren't actually exercised. Because the functions were templated, the compiler just ignored them.
Given that no one is calling them, they clearly serve no purpose. So, they are being cut out rather than fixed.
closes #421
This change is