CI: Move linux and mac configurations to more current platforms #489
Conversation
SeanCurtis-TRI
force-pushed
the
PR_move_ci_to_bionic
branch
from
dcd572a
to
932bc4f
Compare
SeanCurtis-TRI
force-pushed
the
PR_move_ci_to_bionic
branch
from
b406893
to
932bc4f
Compare
SeanCurtis-TRI
force-pushed
the
PR_move_ci_to_bionic
branch
from
932bc4f
to
b89336b
Compare
SeanCurtis-TRI
changed the title
SeanCurtis-TRI
force-pushed
the
PR_move_ci_to_bionic
branch
2 times, most recently
from
1a3fcc3
to
7d8a346
Compare
There was a problem hiding this comment.
+@jamiesnape Assuming this all passes CI. I'd appreciate you doing a reality check on this and making sure I haven't done anything insane or inconsistent.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @jamiesnape)
There was a problem hiding this comment.
osx_image: xcode11.3 would be the more common configuration for the average 10.14 user, but not a big deal.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
SeanCurtis-TRI
force-pushed
the
PR_move_ci_to_bionic
branch
from
7d8a346
to
c56461b
Compare
There was a problem hiding this comment.
Good to know; there were so many flavors of osx 10.14, I wasn't sure whether I should target the first or last. If 11.3 is more representative, I'll bump it again.
@sherm1 do you want to take a look-see?
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @jamiesnape)
There was a problem hiding this comment.
Thanks -- took a quick look. If you and @jamiesnape are happy, I'm happy.
Maybe worth mentioning that the removal of FCL_SUPPRESS_MAYBE_UNINITIALIZED_BEGIN macro might affect some downstream users if they borrowed this for their own purposes. I've no objection to that removal though!
Reviewed 4 of 5 files at r1, 1 of 1 files at r2.
Reviewable status:
SeanCurtis-TRI
force-pushed
the
PR_move_ci_to_bionic
branch
2 times, most recently
from
d03b902
to
83993a0
Compare
There was a problem hiding this comment.
I've updated the changelog to reflect the changes that have taken place since 0.6.1. This includes a note about breaking changes vis a vis the uninitialized macros.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @jamiesnape)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
CHANGELOG.md, line 34 at r3 (raw file):
* Build/Test/Misc * Fixed synatx prevent build in Visual Studio 2015:
BTW spelling and grammar
1. Advance linux to bionic
2. Advance mac to xcode 11.3; that correlates with macOS 10.14.6 which is a
common contemporary of bionic.
3. Appveyor accesses eigen via gitlab (instead of bitbucket).
4. Clean up:
- HierarchyTree::SortByMorton had "maybe" uninitialized values. Cleaned
up initialization and instantiation (using RAII).
SeanCurtis-TRI
force-pushed
the
PR_move_ci_to_bionic
branch
from
83993a0
to
2122d3b
Compare
There was a problem hiding this comment.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @jamiesnape)
CHANGELOG.md, line 34 at r3 (raw file):
Previously, jamiesnape (Jamie Snape) wrote…
BTW spelling and grammar
Siiiiiiiiiigh. Very true.
Move CI to more modern platforms
resolves #490
This change is