Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Petitions Clerk: Send petition package to IRS. (1.4) #110

Closed
32 of 33 tasks
JessicaMarine opened this issue Oct 31, 2018 · 9 comments
Closed
32 of 33 tasks

Petitions Clerk: Send petition package to IRS. (1.4) #110

JessicaMarine opened this issue Oct 31, 2018 · 9 comments

Comments

@JessicaMarine
Copy link

JessicaMarine commented Oct 31, 2018

As a Petitions Clerk, in order notify the IRS of the case filing, I need to send the Petition package to the IRS.

In order for the IRS to know that a case has been filed in the Court, the Petitions clerk transmits/sends the petition package (copy of Petition, Request for place of trial, STIN) to the IRS, who then internally routes the package to the appropriate IRS office and IRS attorney who will be working the case.

Pre-conditions:

  • Petition package has been saved in system.
  • Petition package is associated with Docket #.
  • Petition package is sent to the IRS immediately
  • The Petition package is error-free (all 3 documents have been uploaded by Petitioner)

Acceptance Criteria (Post-conditions):

  • Petitions Clerk can transmit the petition package to the IRS successfully once reviewed
  • Petitions Clerk can verify the case has been forwarded to the IRS
  • Petitions Clerk name, Date and time of service/transmission is captured as metadata in the "Audit Log"
  • Date and time of service/transmission is viewable in the "Docket Record"
  • Is removed from the Petitions Clerk Work Queue
  • Case status is changed to General Docket

Notes:

  • The actual transmission function will be a later story and we may need to be coordinated with IRS IT to figure out how this needs to be accomplished.

Tasks

  • Design how clerk indicates send and success message (Sarah)
  • Create mock IRS API (will/cody)
  • Persistence layer method to talk to mock IRS API (will/cody)
  • Create use case to call the Persistence layer (will/cody)
  • Create use case proxy for the front-end to hit (will/cody)
  • Create Lambda to call the use case (will/cody)
  • Create a sequence that will be called by the UI (will/cody)
  • Code the screen and success message (will/cody)
  • implement changes in design views - see below (eric)
  • review application view (everyone)
  • change case status general to general docket and set font to 14px bold (will)
  • change format of served status in success alert to match the docket record (12/11/18 9:50 AM) (will)
  • add time to docket status after send (will)
  • hide sendtoirs button after sent the first time
  • Change font of general docket button so the padding issue goes away. Talk to Natalie if you have questions.
  • Ensure anchor back up to top with success message works.
  • move payment expando above the tabs

Definition of Done

  • acceptance criteria have been met
  • all code changes have been reviewed, approved, and merged and deployed to develop
  • [x ] all automated unit tests are passing on all supported browsers with coverage > 90%
  • run the browser stack scripts to verify that application is usable in Chrome, Firefox, Safari, Edge and Internet Explorer
  • all automated a11y checks are passing - no new WCAG2.1 or AA contrast issues present
  • 0 errors reported in manual a11y testing
  • all new functionality verified to work with keyboard and osx voiceover
  • all code quality checks are passing - sonar, eslint, html validation, etc.
  • code refactored for clarity and to remove any known technical debt
  • application can be deployed to multiple regions
  • README, other appropriate docs, and swagger/APIs fully updated - all code functions documented with jsdocs
  • performance tests successfully completed and no new significant performance issues found
  • alerting and monitoring for new functionality in place and successfully exercised
  • ui should be touch optimized and responsive (functions on supported mobile devices and optimized for screen sizes as required)
  • usability has been validated
  • npm audit for CVE’s in production library/module dependencies identified and resolved
  • library/module dependencies are up-to-date and are at the latest resolvable version
@JessicaMarine JessicaMarine added the (18) Digital Signatures Digital Signatures label Oct 31, 2018
@tjcurington tjcurington changed the title Petitions Clerk: See how to send petition package to IRS. (1.4) Petitions Clerk: Send petition package to IRS. (1.4) Oct 31, 2018
@turnipsparkle turnipsparkle self-assigned this Nov 27, 2018
@turnipsparkle
Copy link

turnipsparkle commented Nov 28, 2018

Updated 11/28/18
Note: (1) in below line items denotes a change. See comments for details.

Step 1 - Not Validated

  • Three check boxes are not checked
  • Send to IRS button is enabled

Send to IRS 1 HP.png

Step 2 - Sent to IRS

  • (1)Three checkboxes are checked
  • Send to IRS button has been clicked
  • (1)Success message: Line 1 = "Successfully sent to IRS" Line 2 = "[date stamp] [time stamp]"
  • Case Status flag has been changed to "General Docket"
  • (1)Action Required column stays in table but has been cleared
  • (1)Status column changes from "New" to "R Served on [date stamp] [time stamp]" where R stands for "Respondent"
  • Username has been recorded with the date and time stamp but is not displayed on UI
  • Send to IRS button has been removed

Send to IRS 3.png

Ping me with questions!

cc @JessicaMarine @sadlerw

@turnipsparkle
Copy link

turnipsparkle commented Nov 28, 2018

Updated to remove disabled send button spec - not needed.

@JessicaMarine
Copy link
Author

JessicaMarine commented Nov 28, 2018 via email

@turnipsparkle
Copy link

turnipsparkle commented Nov 29, 2018

Updated the spec after talking to Will. (1) in above line items denotes a change.

Changes:

All checkboxes are checked
All available check boxes should be checked before clicking the "Send to IRS" button. If none or only some of the boxes are checked, the system will present a pop up error message consistent with behaviors which have already been implemented. Per Will, USWDS advises against disabling buttons until requirements have been met. Error message wireframe not required.

Success message: Line 1 = "Successfully sent to IRS" Line 2 = "[date stamp] [time stamp]
Removed "at" between date stamp and time stamp for ease of coding. Updated wireframe not required.

Action Required column stays in table but has been cleared
Action Required column will stay but checkboxes and "validated" text will be removed. Will and I agreed that the column should stay for several reasons 1) it's good practice not to remove things from the screen (the Send to IRS button will be an appropriate exception) 2) the column is reusable and 3) it would take time to remove it. Updated wireframe not required.

Status column changes from "New" to "R Served on [date stamp] [time stamp]"
Removed "at" between date stamp and time stamp for ease of coding. Updated wireframe not required.

I think that covers it! @sadlerw feel free to note anything I missed!

cc @JessicaMarine

@dknesek
Copy link

dknesek commented Dec 2, 2018

@sarahridgway If the user selects the 3 "validated" checkboxes and immediately clicks "Send to IRS" what happens? Does the record get saved then sent? They don't have to click "save" first, right?

If it gets saved then sent, do we see two messages, first a confirmation that the case was updated followed closely by "Successfully sent to IRS..."?

@JessicaMarine
Copy link
Author

@sadlerw @uxforgood @klohman

My comments on #110 are:

  1. The Taxpayer doesn't need to see the case status. There seems to be a new column on the table on the Taxpayer's dashboard that needs to be removed.
  2. The "Validate" buttons should disappear after the Petitions Clerk successfully sends the documents to the IRS.
  3. The case status should be "General Docket". It is only showing as "General".

Thanks! Jessica

@turnipsparkle
Copy link

turnipsparkle commented Dec 6, 2018

@JessicaMarine Do we need to display the time stamp (time document was served to IRS) on either the success message or within the docket record table? Right now I think we have date and time.

@uxforgood
Copy link

uxforgood commented Dec 7, 2018

@dubharmonic here are the updated designs for the petitions clerk send to IRS. (The send to IRS button will move to another screen, once we build that screen, but for now it's ok)

image.png

image.png

And for reference, here's what the "Case info" tab looks like after filing fee is paid (for design reference only - not intrinsic to the function of this user story)

image.png

@kkoskelin
Copy link

image
Accessibility testing using Safari + VoiceOver (and keyboard) is complete with one caveat above. Attempting to open PDFs currently will generate a "blocked popup" message in both Chrome and Safari. It is important to note that the current method of opening PDFs in a new window is going to be changing in the near-future, rendering this issue moot. However, if it is of great concern, we could discuss possible solutions.
cc: @JessicaMarine

sadlerw added a commit that referenced this issue Dec 13, 2018
@codyseibert codyseibert mentioned this issue Dec 19, 2018
@codyseibert codyseibert mentioned this issue Jan 8, 2019
ericsorenson pushed a commit that referenced this issue Nov 20, 2019
Document the new process for merging to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants