Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint 4 #410

Merged
merged 410 commits into from
Dec 19, 2018
Merged

Sprint 4 #410

merged 410 commits into from
Dec 19, 2018

Conversation

codyseibert
Copy link

@codyseibert codyseibert commented Dec 19, 2018

User Stories

#110 - Send Petition Package to IRS

  • added a "submit to irs" button on the case details page for the "petitionsclerk" role login which allows them to mark the package as sent to the irs (not real sending functionality for this story at this point

screen shot 2018-12-17 at 10 57 45 am

#111 - Respondent - File and Answer

  • added a File Document button on the case details page for the "respondent" role which navigates the user to another page which allows them to select a document type and upload

screen shot 2018-12-17 at 10 58 55 am

screen shot 2018-12-17 at 11 00 26 am

#112 - Respondent - File a Stipulated Decision

  • similar to 111, but with a different file type (see image above)

#113 - Docket Clerk - Forward Stipulated Decision (In Progress)

Reminder, there are 4 logins now

  • respondent
  • docketclerk
  • taxpayer
  • petitionsclerk

Deploy Steps

  • Login to Jenkins
  • click on the ef-cms-shared job
  • click on configure job
  • change "script path" to "shared/Jenkinsfile"

Code Architecture Related Changes

  • renamed business folder to shared
  • no longer having separate tables for each entity type in dynamodb; instead, we are writing everything to a 'efcms-dev' table. This was an attempt to move away from a "relational" approach; the dynamodb best practices documentation suggests only having a single table for your application.
  • removed the efcms-cases table
  • removed the efcms-documents table
  • removing the test cases that cover our lambda files since they are redundant tests; the same use cases are verified in the "shared" test cases

sadlerw and others added 27 commits December 17, 2018 07:31
Refactor 112/111 Remove Proxied Persistence Methods
ignoring the humble objects from coverage checks in sonar
Copy link

@kkoskelin kkoskelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When tests pass, 👍

@codyseibert codyseibert merged commit f2ab564 into master Dec 19, 2018
codyseibert pushed a commit that referenced this pull request Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants