Support serialization of typed arrays #155
Conversation
There was a problem hiding this comment.
Hi @tomhooijenga! Thank you for creating this PR, I like it a lot! I have two minor nits. I think you didn't click the "allow maintainers to push changes" checkbox, so I attached two (very minor) commits I'd love to see added :)
commits.zip
|
Hi @Skn0tt, I've added your commits. The checkbox seems to be checked... I've turned it off and on again, maybe that helps. |
src/transformer.ts
Outdated
| @@ -193,6 +201,35 @@ const symbolRule = compositeTransformation( | |||
| } | |||
| ); | |||
|
|
|||
| const constructorToName = Object.fromEntries( | |||
There was a problem hiding this comment.
Object.fromEntries is node 12 and up but the tests also run 10. Does SuperJSON still actively support Node 10?
src/transformer.ts
Outdated
| | 'regexp' | ||
| | 'Date' | ||
| | 'Error' | ||
| | 'typed-array'; |
There was a problem hiding this comment.
I think this can be removed entirely because it is defined in CompositeTypeAnnotation
|
@allcontributors please add @tomhooijenga for bug, code |
|
I've put up a pull request to add @tomhooijenga! 🎉 |
This fixes #144.