Added Confirm Warning for Fully Enable feature #665
Conversation
There was a problem hiding this comment.
As mentioned in #654 having this ability behind a UI configuration would be helpful.
lib/flipper/ui/views/feature.erb
Outdated
| @@ -225,7 +225,7 @@ | |||
| <div class="row"> | |||
| <% unless @feature.boolean_value %> | |||
| <div class="col"> | |||
| <button type="submit" name="action" value="Enable" class="btn btn-outline-success btn-block"> | |||
| <button type="submit" name="action" value="Enable" id="confirm-warn-enable" class="btn btn-outline-success btn-block"> | |||
There was a problem hiding this comment.
It might be better to make this id a little more generic. Something like enable_feature__button. That would stay consistent with some of the other id attributes on buttons.
There was a problem hiding this comment.
Hi @thetimbanks changed the id as requested, it truly makes sense! Can i please get it merged, i believe it would be of great help for our product, if this small change could merge.
There was a problem hiding this comment.
There was a problem hiding this comment.
Hi @thetimbanks Added the configuration option and it is set to false by default.
There was a problem hiding this comment.
Reminder @thetimbanks for merging the PR, cc @rsanheim @bkeepers @delynn
|
This is my fault. I’ll take a look today or tomorrow and get it merged.
On September 28, 2022, David Grevink ***@***.***> wrote:
@Dhruv8 commented on this pull request.
In lib/flipper/ui/views/feature.erb
<#665 (comment)>:
@@ -225,7 +225,7 @@ <div class="row"> <% unless @feature.boolean_value
%> <div class="col"> - <button type="submit" name="action"
value="Enable" class="btn btn-outline-success btn-block"> + <button
type="submit" name="action" value="Enable" id="confirm-warn-enable"
class="btn btn-outline-success btn-block">
Reminder @thetimbanks <https://github.com/thetimbanks> for merging the
PR, cc @rsanheim <https://github.com/rsanheim>
@bkeepers <https://github.com/bkeepers>
@delynn <https://github.com/delynn>
—
Reply to this email directly, view it on GitHub
<#665 (comment)>,
or unsubscribe <https://github.com/notifications/unsubscribe-
auth/AAAAB27ZBJPQLYPT5SUFIATWAPQ4LANCNFSM6AAAAAAQIP774U>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Added Confirm Warning when fully enabling a feature