Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation dialog before disabling a flipper #813

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Add confirmation dialog before disabling a flipper #813

merged 2 commits into from
Jan 10, 2024

Conversation

jmikhail
Copy link

@jmikhail jmikhail commented Jan 9, 2024

Similar to #665, this PR adds a confirmation dialog when disabling a flipper. The dialog is configurable with confirm_disable.

Copy link
Collaborator

@bkeepers bkeepers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bkeepers bkeepers merged commit 8a09bac into flippercloud:main Jan 10, 2024
36 checks passed
@luisott
Copy link

luisott commented Jan 10, 2024

Thank you for this!

@bkeepers
Copy link
Collaborator

@luisott 1.2.0 is out with this change. Thanks for your help! https://blog.flippercloud.io/flipper-1-2-0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants