Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stable Rust toolchain #58

Open
2 of 4 tasks
dcoles opened this issue Mar 18, 2023 · 2 comments
Open
2 of 4 tasks

Support stable Rust toolchain #58

dcoles opened this issue Mar 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@dcoles
Copy link
Collaborator

dcoles commented Mar 18, 2023

Currently Rust for Flipper Zero requires a nightly toolchain to build binaries. This makes development somewhat more difficult as we have to regularly update this to pull in new features or bug fixes.

Blockers to supporting a stable Rust toolchain

@dcoles dcoles added the enhancement New feature or request label Mar 18, 2023
@dcoles
Copy link
Collaborator Author

dcoles commented Mar 18, 2023

A possible alternative to waiting for no-unique-section-names is to teach the Flipper Zero linker about non-unique section names.

@str4d str4d mentioned this issue Apr 2, 2023
@str4d str4d mentioned this issue Jun 8, 2023
str4d added a commit that referenced this issue Jun 9, 2023
We instead can rely on `crates/rust-toolchain.toml` to pin the nightly
version we are using. This has two benefits:
- We are not exposed to random nightly breakage in CI.
- Once we move to stable Rust (#58), this will
  ensure we build and test against MSRV.
@dcoles
Copy link
Collaborator Author

dcoles commented Sep 11, 2024

It appears that the Flipper Zero linker can now handle non-unique section names making -Z no-unique-section-names unneeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant