Yapf #38
Merged
Yapf #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenevinitsky
requested review from
AboudyKreidieh,
cathywu and
kanaadp
as code owners
|
I'm sorry for whoever has to code review this. |
Merged
nskh
pushed a commit
to nskh/flow
that referenced
this pull request
Aug 25, 2018
fixing typo (rllab->rllib)
AboudyKreidieh
approved these changes
Aug 25, 2018
|
also, people should merge right away or this'll be a nightmare later |
|
Yeah that’s the logic. A strict style guide that we can enforce with one line of code will be useful as we grow. Not sure I love every aspect of it either; we can create a style file for yapf if you have preferences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added yapf changes to make the code look a bit nicer. All changes are entirely cosmetic, nothing else.