Skip to content

Conversation

eugenevinitsky
Copy link
Member

  • The links to conda and miniconda were broken
  • Makefile for docs was missing

@nskh
Copy link
Collaborator

nskh commented Aug 25, 2018

This commit includes all of the YAPF changes - so are we waiting on #38 before merging this in? Would be best if it was separate, right?

Copy link
Member

@AboudyKreidieh AboudyKreidieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AboudyKreidieh
AboudyKreidieh approved these changes Aug 27, 2018
@AboudyKreidieh AboudyKreidieh merged commit dfe19f5 into master Aug 27, 2018
@AboudyKreidieh AboudyKreidieh deleted the setup_fix branch August 27, 2018 07:58
kjang96 pushed a commit to kjang96/flow-1 that referenced this pull request Sep 1, 2018
crystalzyan pushed a commit to crystalzyan/flow that referenced this pull request Dec 1, 2018
Setup fix
- The links to conda and miniconda were broken 
- Makefile for docs was missing
eugenevinitsky added a commit that referenced this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants