This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Flow coverage should be done ONLY for files linted with flow #184
Labels
Comments
|
Yeah agreed, PRs are welcome 👍 |
Mayank1791989
added a commit
to Mayank1791989/flow-for-vscode
that referenced
this issue
Feb 16, 2019
Client (closes flow#302, flow#304, flow#253, flow#228, flow#201, flow#195, flow#189, flow#184, flow#165, flow#81) - add multi flowconfig support - add vscode multi-root workspace support - client is now lazily created if flowconfig found - fix document selector. New implementation will handle following cases - Single workspace with multiple flowconfig - Multiple workspace with multiple flowconfig Get Flow-Bin - improve|fix logic to find flow-bin (fixes flow#282, flow#240, flow#209) - fix flow bundled with plugin not working issue: we are using .bin/flow but vscode never includes .bin in plugin package - add logs while finding flow-bin to debug issues - plugin now doesn't check for node (closes flow#290) - pathToFlow: value is normalized and .cmd is added so same value can be used for linux, osx & win Error handling (closes flow#200) - [feat] improve error handling. - [feat] Show action in errors so that user can recover from error without restarting vscode Commands - [feat] Add commands - Toggle coverage - Show client status - Restart Client - Log Client Debug Info - Show output channel Status Widget Include more info in status widget to help user know what this plugin is using - [feat] include flow version - [feat] add flow info section in widget tooltip which includes - path to .flowconfig - flow version - path to "flow" binary Settings - flow.coverageSeverity to control type coverage diagnostic severity - flow.useBundledFlow control use of flow bundled with this plugin - flow.trace.server log communication between vscode and flow lsp - flow.logLevel control log level of plugin logs
Mayank1791989
added a commit
to Mayank1791989/flow-for-vscode
that referenced
this issue
Feb 18, 2019
Client (closes flow#302, flow#308, flow#253, flow#228, flow#201, flow#195, flow#189, flow#184, flow#165, flow#81) - add multi flowconfig support - add vscode multi-root workspace support - client is now lazily created if flowconfig found - fix document selector. New implementation will handle following cases - Single workspace with multiple flowconfig - Multiple workspace with multiple flowconfig Get Flow-Bin - improve|fix logic to find flow-bin (fixes flow#282, flow#240, flow#209) - fix flow bundled with plugin not working issue: we are using .bin/flow but vscode never includes .bin in plugin package - add logs while finding flow-bin to debug issues - plugin now doesn't check for node (closes flow#290) - pathToFlow: value is normalized and .cmd is added so same value can be used for linux, osx & win Error handling (closes flow#200) - [feat] improve error handling. - [feat] Show action in errors so that user can recover from error without restarting vscode Commands - [feat] Add commands - Toggle coverage - Show client status - Restart Client - Log Client Debug Info - Show output channel Status Widget Include more info in status widget to help user know what this plugin is using - [feat] include flow version - [feat] add flow info section in widget tooltip which includes - path to .flowconfig - flow version - path to "flow" binary Settings - flow.coverageSeverity to control type coverage diagnostic severity - flow.useBundledFlow control use of flow bundled with this plugin - flow.trace.server log communication between vscode and flow lsp - flow.logLevel control log level of plugin logs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It's bizarre that Flow coverage is enabled for a markdown file, e.g. README.md. It doesn't make sense.
The text was updated successfully, but these errors were encountered: