Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Do not require global Flow #81

Closed
polizz opened this issue Feb 14, 2017 · 2 comments
Closed

Do not require global Flow #81

polizz opened this issue Feb 14, 2017 · 2 comments

Comments

@polizz
Copy link

polizz commented Feb 14, 2017

We do not use Flow in every project and even the ones where we do, it's not a global dependency - it's installed local every time. Thus, we get this error a lot when opening any project. Please consider making the global check fail gracefully.

screen shot 2017-02-14 at 9 26 14 am
@orta
Copy link
Contributor

orta commented Feb 14, 2017

I think it would make sense to add a recursive backwards check for a .flowconfig through the folders from the current working directory here before then allowing the extension to activate 👍

@alexdevico
Copy link

@polizz as workaround you can disable flow extension in "User Settings" and enable it in "Workspace Settings" for projects that require it. Or disable it for some projects (if most of projects require flow)

Currently extension doesn't check that it's required for project or not.

orta added a commit that referenced this issue Mar 22, 2017
@orta
Don't load Flow if a .flowconfig cannot be found on a recursive searc…
ef24057 
…h from workspace root - #81
orta added a commit that referenced this issue Mar 22, 2017
@orta
Don't load Flow if a .flowconfig cannot be found on a recursive searc…
28f184a 
…h from workspace root - #81
@orta orta mentioned this issue Mar 22, 2017
Closed
Mayank1791989 added a commit to Mayank1791989/flow-for-vscode that referenced this issue Feb 16, 2019
@Mayank1791989
feat(lsp): add multi config & multi-root workspace support
00a4697 
Client (closes flow#302, flow#304, flow#253, flow#228, flow#201, flow#195, flow#189, flow#184, flow#165, flow#81)
- add multi flowconfig support
- add vscode multi-root workspace support
- client is now lazily created if flowconfig found
- fix document selector.

New implementation will handle following cases
- Single workspace with multiple flowconfig
- Multiple workspace with multiple flowconfig

Get Flow-Bin
- improve|fix logic to find flow-bin (fixes flow#282, flow#240, flow#209)
- fix flow bundled with plugin not working
  issue: we are using .bin/flow but vscode never includes .bin in plugin package
- add logs while finding flow-bin to debug issues
- plugin now doesn't check for node (closes flow#290)
- pathToFlow: value is normalized and .cmd is added so same value can
be used for linux, osx & win

Error handling (closes flow#200)
- [feat] improve error handling.
- [feat] Show action in errors so that user can recover from error
  without restarting vscode

Commands
- [feat] Add commands
  - Toggle coverage
  - Show client status
  - Restart Client
  - Log Client Debug Info
  - Show output channel

Status Widget
Include more info in status widget to help user know what this plugin is using
- [feat] include flow version
- [feat] add flow info section in widget tooltip which includes
  - path to .flowconfig
  - flow version
  - path to "flow" binary

Settings
- flow.coverageSeverity to control type coverage diagnostic severity
- flow.useBundledFlow control use of flow bundled with this plugin
- flow.trace.server log communication between vscode and flow lsp
- flow.logLevel control log level of plugin logs
Mayank1791989 added a commit to Mayank1791989/flow-for-vscode that referenced this issue Feb 18, 2019
@Mayank1791989
feat(lsp): add multi config & multi-root workspace support
b5be657 
Client (closes flow#302, flow#308, flow#253, flow#228, flow#201, flow#195, flow#189, flow#184, flow#165, flow#81)
- add multi flowconfig support
- add vscode multi-root workspace support
- client is now lazily created if flowconfig found
- fix document selector.

New implementation will handle following cases
- Single workspace with multiple flowconfig
- Multiple workspace with multiple flowconfig

Get Flow-Bin
- improve|fix logic to find flow-bin (fixes flow#282, flow#240, flow#209)
- fix flow bundled with plugin not working
  issue: we are using .bin/flow but vscode never includes .bin in plugin package
- add logs while finding flow-bin to debug issues
- plugin now doesn't check for node (closes flow#290)
- pathToFlow: value is normalized and .cmd is added so same value can
be used for linux, osx & win

Error handling (closes flow#200)
- [feat] improve error handling.
- [feat] Show action in errors so that user can recover from error
  without restarting vscode

Commands
- [feat] Add commands
  - Toggle coverage
  - Show client status
  - Restart Client
  - Log Client Debug Info
  - Show output channel

Status Widget
Include more info in status widget to help user know what this plugin is using
- [feat] include flow version
- [feat] add flow info section in widget tooltip which includes
  - path to .flowconfig
  - flow version
  - path to "flow" binary

Settings
- flow.coverageSeverity to control type coverage diagnostic severity
- flow.useBundledFlow control use of flow bundled with this plugin
- flow.trace.server log communication between vscode and flow lsp
- flow.logLevel control log level of plugin logs
@Mayank1791989 Mayank1791989 mentioned this issue Feb 18, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't load Flow if a .flowconfig cannot be found flow/flow-for-vscode
4 participants
@orta @Mayank1791989 @polizz @alexdevico