Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD: Labeling of Tests #648

Closed
2 of 3 tasks
EagleoutIce opened this issue Feb 7, 2024 · 1 comment · Fixed by #654
Closed
2 of 3 tasks

PD: Labeling of Tests #648

EagleoutIce opened this issue Feb 7, 2024 · 1 comment · Fixed by #654
Assignees
Labels
done The issue is only open as it relates to a larger feature which is not yet completed test Relates to tests specifically

Comments

@EagleoutIce
Copy link
Member

EagleoutIce commented Feb 7, 2024

  • create branch from dataflow-v2
  • label your first test using label(<name>, <ids...>)
  • label all other tests after checking back with @EagleoutIce

Only label elements with a 🟩, 🔶, and 🔴, not "super"/"abstract" labels like expressions.

Whenever you encounter

  • too long/cumbersome label names
  • wrong descriptions alongside a label
  • too short test names
  • or any other thing that can be improved
    improve it.

For all tests under dataflow/:

  • Handle Expressions from Operators
  • Unto Important Built-Ins>Parsing

Use your good sense: if another label applies for a test case, try to add it as well.

Even if unsure: add an empty label label().

Use, for example, the access>const access>single constant test for guidance.

@EagleoutIce
Copy link
Member Author

Please comment any problems/room for improvement encountered.

@EagleoutIce EagleoutIce added the test Relates to tests specifically label Feb 7, 2024
@Ehcsan Ehcsan linked a pull request Feb 8, 2024 that will close this issue
@EagleoutIce EagleoutIce added the done The issue is only open as it relates to a larger feature which is not yet completed label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done The issue is only open as it relates to a larger feature which is not yet completed test Relates to tests specifically
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants