648 pd labeling of tests #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dataflow-v2 #654 +/- ##
============================================
Coverage 66.10% 66.10%
============================================
Files 266 266
Lines 7984 7984
Branches 1221 1221
============================================
Hits 5278 5278
Misses 2420 2420
Partials 286 286 ☔ View full report in Codecov by Sentry. |
EagleoutIce
reviewed
Feb 9, 2024
| @@ -86,7 +86,7 @@ describe('Atomic (dataflow information)', withShell((shell) => { | |||
| .addEdge('2', '1', EdgeType.Reads, 'always') | |||
| .addEdge('5', '4', EdgeType.Reads, 'always') | |||
| ) | |||
| assertDataflow('assign on access', shell, | |||
| assertDataflow(label('assign on access', 'local-left-assignment', 'single-bracket-access'), shell, | |||
There was a problem hiding this comment.
normal-name (or name-normal :D not sure) would fit as well :) you can give the number as well.
|
I claim this as part of the norm-desugar labeling. |
|
This pull request is included in v2.0.0 (see Release v2.0.0 (Dataflow v2)). |
1 similar comment
|
This pull request is included in v2.0.0 (see Release v2.0.0 (Dataflow v2)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labeling of tests according to #648