out_datadog: fix/add error handling for all flb_sds calls #5930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PettitWesley
force-pushed
the
flb_sds_datadog_master
branch
from
461c204
to
a6f1f84
Compare
PettitWesley
force-pushed
the
flb_sds_datadog_master
branch
from
a6f1f84
to
9fbb4ba
Compare
PettitWesley
force-pushed
the
flb_sds_datadog_master
branch
from
9fbb4ba
to
9b4ebbe
Compare
|
Can we please prioritise this PR ? Due to this issue we have been facing regular fluentbit crashes while sending logs to datadog. |
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
PettitWesley
force-pushed
the
flb_sds_datadog_master
branch
from
9b4ebbe
to
67f5df5
Compare
|
@edsiper This is ready for merge I think. CI seems to be passing. This is a bug fix. |
This was referenced Feb 4, 2023
sumitd2
pushed a commit
to sumitd2/fluent-bit
that referenced
this pull request
Feb 8, 2023
Signed-off-by: Wesley Pettit <wppttt@amazon.com> Signed-off-by: root <root@sumit-acs.novalocal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wesley Pettit wppttt@amazon.com
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.