data_dog: partially revert recent datadog PR to avoid segfault

[matthewfala]

See 1.9 PR: #6785

We noticed that the recent datadog pr triggers a segfault when provider option is set to ecs. After a lot of investigation, we were unable to find the root cause of the segfault, but discovers that it exists during a some random network call, which has nothing to do with the error handling code added in the PR, that when removed, resolves the segfault.

As a solution, we partially revert the recent Datadog pr that mysteriously triggers this segfault. It is just some simple error handling code that was recently added.

Partial revert provider ecs code of Datadog recent pr that triggers segfaults:
#5930
#5929

See the segfault reports in aws-for-fluent-bit repo here:
aws/aws-for-fluent-bit#491

Signed-off-by: Matthew Fala falamatt@amazon.com

---

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

• Example configuration file for the change
• Debug log output from testing the change

• Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

• Run local packaging test showing all targets (including any new ones) build.
• Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

• Documentation required for this feature

Backporting

• Backport to latest stable release.

---

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

[nokute78]

Note: #6785 (comment)

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.