-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add test to check the service status with updating from v4 #755
Merged
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
force-pushed
the
add-test-to-check-restart
branch
from
December 5, 2024 07:51
9d091ba
to
9555bcf
Compare
Watson1978
force-pushed
the
add-test-to-check-restart
branch
from
December 6, 2024 00:26
9555bcf
to
7e207d2
Compare
Watson1978
force-pushed
the
add-test-to-check-restart
branch
from
December 6, 2024 01:27
7e207d2
to
b3ccfb5
Compare
Looks like restart does not occur unexpectedly when updating v4 to v5. |
daipom
reviewed
Dec 6, 2024
Watson1978
force-pushed
the
add-test-to-check-restart
branch
from
December 6, 2024 06:11
b3ccfb5
to
386f38f
Compare
…from v4 Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
add-test-to-check-restart
branch
from
December 6, 2024 06:19
386f38f
to
f47a960
Compare
daipom
reviewed
Dec 6, 2024
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
add-test-to-check-restart
branch
from
December 6, 2024 08:30
ae00e5e
to
e53a345
Compare
Watson1978
changed the title
ci: add test to check that fluentd should be restarted with updating from v4
ci: add test to check that fluentd should be restarted with updating from v4 when service was stopped
Dec 6, 2024
Watson1978
changed the title
ci: add test to check that fluentd should be restarted with updating from v4 when service was stopped
ci: add test to check the service status with updating from v4
Dec 6, 2024
daipom
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Watson1978
added a commit
to Watson1978/fluent-package-builder
that referenced
this pull request
Dec 9, 2024
…t#755) This PR will add test to confirm that fluentd should be restarted with updating from v4 --------- Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add test to confirm that fluentd should be restarted with updating from v4