Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add test to check the service status with updating from v4 #755

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Dec 5, 2024

This PR will add test to confirm that fluentd should be restarted with updating from v4

@Watson1978 Watson1978 force-pushed the add-test-to-check-restart branch from 9d091ba to 9555bcf Compare December 5, 2024 07:51
@Watson1978 Watson1978 marked this pull request as ready for review December 5, 2024 09:02
@Watson1978 Watson1978 requested a review from daipom December 5, 2024 09:02
@Watson1978 Watson1978 marked this pull request as draft December 6, 2024 00:19
@Watson1978 Watson1978 force-pushed the add-test-to-check-restart branch from 9555bcf to 7e207d2 Compare December 6, 2024 00:26
@Watson1978 Watson1978 changed the base branch from feature-nodowntime to master December 6, 2024 01:26
@Watson1978 Watson1978 force-pushed the add-test-to-check-restart branch from 7e207d2 to b3ccfb5 Compare December 6, 2024 01:27
@daipom
Copy link
Contributor

daipom commented Dec 6, 2024

Looks like restart does not occur unexpectedly when updating v4 to v5.
(td-agent v4 (active) -> fluent-package v5)

@Watson1978 Watson1978 force-pushed the add-test-to-check-restart branch from b3ccfb5 to 386f38f Compare December 6, 2024 06:11
…from v4

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
@Watson1978 Watson1978 force-pushed the add-test-to-check-restart branch from 386f38f to f47a960 Compare December 6, 2024 06:19
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
@Watson1978 Watson1978 force-pushed the add-test-to-check-restart branch from ae00e5e to e53a345 Compare December 6, 2024 08:30
@Watson1978 Watson1978 marked this pull request as ready for review December 6, 2024 08:36
@Watson1978 Watson1978 changed the title ci: add test to check that fluentd should be restarted with updating from v4 ci: add test to check that fluentd should be restarted with updating from v4 when service was stopped Dec 6, 2024
@Watson1978 Watson1978 changed the title ci: add test to check that fluentd should be restarted with updating from v4 when service was stopped ci: add test to check the service status with updating from v4 Dec 6, 2024
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom merged commit ade6bf0 into fluent:master Dec 9, 2024
107 checks passed
@Watson1978 Watson1978 deleted the add-test-to-check-restart branch December 9, 2024 01:57
Watson1978 added a commit to Watson1978/fluent-package-builder that referenced this pull request Dec 9, 2024
…t#755)

This PR will add test to confirm that fluentd should be restarted with
updating from v4

---------

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com>
@kenhys kenhys added this to the 5.2.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants