Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add test to check the service status with updating from v4 #755

Merged
merged 2 commits into from
Dec 9, 2024
Merged

ci: add test to check the service status with updating from v4 #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f47a960
ci: add test to check that fluentd should be restarted with updating …
Watson1978 Dec 5, 2024
e53a345
Fix comment
Watson1978 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions fluent-package/apt/systemd-test/update-from-v4.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ sudo apt install -y curl ca-certificates
curl -fsSL https://toolbelt.treasuredata.com/sh/install-${distribution}-${code_name}-td-agent4.sh | sh

systemctl status --no-pager td-agent
main_pid=$(eval $(systemctl show td-agent --property=MainPID) && echo $MainPID)

# Generate garbage files
touch /etc/td-agent/a\ b\ c
Expand All @@ -18,6 +19,11 @@ for d in $(seq 1 10); do
touch /var/log/td-agent/$d.log
done

# When it updates from v4, the service needs to be stopped to restart fluentd after installation.
# Note: This behavior is not expected, and maybe it should be fixed.
# The cause is unknown. For deb, usually, restart should happen when the service was active before the update.
sudo systemctl stop td-agent

# Install the current
case $1 in
local)
Expand Down Expand Up @@ -49,6 +55,9 @@ esac
systemctl status --no-pager fluentd
systemctl status --no-pager td-agent

# Fluentd should be restarted when update from v4.
test $main_pid -ne $(eval $(systemctl show fluentd --property=MainPID) && echo $MainPID)
daipom marked this conversation as resolved.
Show resolved Hide resolved

# Test: restoring td-agent service alias
sudo systemctl stop fluentd
sudo systemctl unmask td-agent
Expand Down
4 changes: 4 additions & 0 deletions fluent-package/yum/systemd-test/update-from-v4.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ sudo $DNF install -y td-agent-${td_agent_version}-1.*.x86_64

sudo systemctl enable --now td-agent
systemctl status --no-pager td-agent
main_pid=$(eval $(systemctl show td-agent --property=MainPID) && echo $MainPID)

# Generate garbage files
touch /etc/td-agent/a\ b\ c
Expand All @@ -40,6 +41,9 @@ systemctl status --no-pager fluentd # Migration process starts the service autom
sudo systemctl enable fluentd # Enable the unit name alias
systemctl status --no-pager td-agent

# Fluentd should be restarted when update from v4.
test $main_pid -ne $(eval $(systemctl show fluentd --property=MainPID) && echo $MainPID)

# Test: config migration
test -h /etc/td-agent
test -h /etc/fluent/fluentd.conf
Expand Down
Loading