Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to manifest v3 #32

Closed
jobara opened this issue Apr 7, 2022 · 1 comment · Fixed by #40 or #44
Closed

Update to manifest v3 #32

jobara opened this issue Apr 7, 2022 · 1 comment · Fixed by #40 or #44
Labels
bug Something isn't working
Milestone
v0.3.0

Comments

@jobara
Copy link
Member

jobara commented Apr 7, 2022

Describe the bug

Manifest Version 2 has been deprecated. We have until Jan 2023 to update at which point v2 manifest extensions will no longer run in the browser.

Additional context or notes

Manifest v3 transition timeline
@jobara jobara added the bug Something isn't working label Apr 7, 2022
@jobara jobara added this to the v0.3.0 milestone Apr 12, 2022
@jobara
Copy link
Member Author

jobara commented May 10, 2022

It looks like the keyboard shortcut to open the extension won't work until Chrome 103.
https://bugs.chromium.org/p/chromium/issues/detail?id=1190476

@jobara jobara mentioned this issue Sep 20, 2022
Closed
cindyli added a commit to cindyli/uio-plus that referenced this issue Oct 28, 2022
@cindyli
fluid-projectGH-32: in progress of adding tests for background.js
b33d769
cindyli added a commit to cindyli/uio-plus that referenced this issue Nov 1, 2022
@cindyli
fluid-projectGH-32: add unit test for background.js
69c17a2
cindyli added a commit to cindyli/uio-plus that referenced this issue Nov 11, 2022
@cindyli
fluid-projectGH-32: add tests for enhancer.js using sinon-chrome
bacbfdf
cindyli added a commit to cindyli/uio-plus that referenced this issue Dec 7, 2022
@cindyli
fluid-projectGH-32: Finish writing tests and clean up
6402f55
cindyli added a commit to cindyli/uio-plus that referenced this issue Dec 8, 2022
@cindyli
fluid-projectGH-32: modify the npm build script
4565f2c
cindyli added a commit to cindyli/uio-plus that referenced this issue Dec 8, 2022
@cindyli
fluid-projectGH-32: update the node version used by Github CI
9f74561
@cindyli cindyli mentioned this issue Dec 8, 2022
Merged
cindyli added a commit to cindyli/uio-plus that referenced this issue Dec 19, 2022
@cindyli
fluid-projectGH-32: replace ; with && when defining npm tasks
6e0fef0
cindyli added a commit to cindyli/uio-plus that referenced this issue Dec 19, 2022
@cindyli
fluid-projectGH-32: add a code comment
fa68e7f
cindyli added a commit to cindyli/uio-plus that referenced this issue Dec 20, 2022
@cindyli
fluid-projectGH-32: add sinon into devDependencies
12c6982
cindyli added a commit to cindyli/uio-plus that referenced this issue Dec 20, 2022
@cindyli
fluid-projectGH-32: defer javascript loading to fix no container error
ffb695d
cindyli added a commit to cindyli/uio-plus that referenced this issue Dec 20, 2022
@cindyli
fluid-projectGH-32: fix a couple of issues found in code review
c443e40
cindyli added a commit to cindyli/uio-plus that referenced this issue Dec 20, 2022
@cindyli
fluid-projectGH-32: fix the no container error at enabling UIO+
58a7f5f
cindyli added a commit to cindyli/uio-plus that referenced this issue Dec 20, 2022
@cindyli
fluid-projectGH-32: disable the page level reading
ebd7b55
cindyli added a commit to cindyli/uio-plus that referenced this issue Dec 20, 2022
@cindyli
fluid-projectGH-32: address review suggestions
3df6fe2
jobara added a commit that referenced this issue Dec 21, 2022
@cindyli @jobara
feat: update to manifest v3 (Resolves: #32, #33, #29) (#40)
cad0c64 
* wip: update to manifest v3

* chore: cleanup suggested in code review

* refactor: update dependencies

* chore: more cleanup from review

* GH-32: in progress of adding tests for background.js

* GH-32: add unit test for background.js

* GH-32: add tests for enhancer.js using sinon-chrome

* GH-32: Finish writing tests and clean up

* GH-32: modify the npm build script

* GH-32: update the node version used by Github CI

* GH-32: replace ; with && when defining npm tasks

* GH-32: add a code comment

* GH-32: add sinon into devDependencies

* GH-32: defer javascript loading to fix no container error

* GH-32: fix a couple of issues found in code review

* GH-32: fix the no container error at enabling UIO+

* GH-32: disable the page level reading

* GH-32: address review suggestions

Co-authored-by: Justin Obara <obara.justin@gmail.com>
@github-actions github-actions bot mentioned this issue Dec 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.3.0
1 participant
@jobara