feat!: update to manifest v3 (Resolves: #32, #33, #29) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cindyli
reviewed
Sep 20, 2022
.npmignore
Outdated
| @@ -6,12 +6,10 @@ | |||
| .gitignore | |||
| .npmignore | |||
| .nycrc | |||
| .vagrant | |||
| chrome_web_store.png | |||
| coverage | |||
| Gruntfile.js | |||
There was a problem hiding this comment.
Gruntfile.js can be removed too?
| @@ -55,7 +55,16 @@ This will generate a `dist` directory at the root of the project. This is used w | |||
| can also be run as an unpacked extension. | |||
|
|
|||
| ```bash | |||
There was a problem hiding this comment.
In the "Dependencies" section, the dependency on "grunt-cli" probably can be removed too.
| @@ -110,7 +114,7 @@ _**NOTE:** Published versions can be installed from the [Chrome Web Store]( | |||
|
|
|||
| ### BSD 3-Clause | |||
|
|
|||
| * [Infusion v3.0.0-dev](https://fluidproject.org/infusion.html) | |||
| * [Infusion v4.0.0](https://fluidproject.org/infusion.html) | |||
There was a problem hiding this comment.
package.json is using infusion 4.1.0. The current latest infusion version is 4.3.0.
| @@ -1,4 +1,3 @@ | |||
| /build/ | |||
| /dist/ | |||
There was a problem hiding this comment.
/.vagrant/ at line 6 in this file can be removed too.
|
Closed as the work continues at #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #32
Resolves: #33
Resolves: #29
The remaining TODOs are noted in the TODOs file.
Migration docs: