FC-1429: Don't consider any flakes for a collection when no ecount set #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max subject id used by the database for a particular collection is set on the db in the `ecounts` map as flakes in that collection are added to the ledger. There's no value set in the map for that collection before any flakes in that collection have been added. This has the effect of making the collection have no upper limit during query processing, and flakes in any collection that comes after the one in question are considered for analytical queries. This patch changes the query engine so it doesn't load any flakes from collections that don't have an ecount set because the ecount not being set means there aren't any flakes in that collection.
zonotope
changed the title
dpetran
reviewed
Aug 23, 2022
src/fluree/db/query/analytical.cljc
Outdated
| @@ -420,7 +420,11 @@ | |||
| (let [partition (dbproto/-c-prop db :partition (last clause)) | |||
| max-sid (-> db :ecount (get partition)) | |||
| min-sid (flake/min-subject-id partition) | |||
| flakes (<? (query-range/index-range db :spot >= [max-sid] <= [min-sid])) | |||
| flakes (if-not max-sid | |||
There was a problem hiding this comment.
This is a nit-pick, but a tiny readability preference I have is to avoid negated conditionals if I can simply swap the then/else clauses. It saves me an extra brain cycle when reading later. But I'll defer to your judgment either way 👍
There was a problem hiding this comment.
Yeah, I tend to agree with you, but I explicitly picked if-not this time because the deciding factor in my mind was whether or not max-sid was null. However, this is completely arbitrary, so I changed it to an if because there should be a non-arbitrary reason to use if-not. Thanks for the suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max subject id used by the database for a particular collection is set on
the db in the
ecountsmap as flakes in that collection are added to theledger. There's no value set in the map for that collection before any flakes in
that collection have been added. This has the effect of making the collection
have no upper limit during query processing, and flakes in any collection that
comes after the one in question are considered for analytical queries.
This patch changes the query engine so it doesn't load any flakes from
collections that don't have an ecount set because the ecount not being set means
there aren't any flakes in that collection.