Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FC-1429: Don't consider any flakes for a collection when no ecount set #194

Merged
merged 2 commits into from
Aug 23, 2022
Merged

FC-1429: Don't consider any flakes for a collection when no ecount set #194

merged 2 commits into from
Aug 23, 2022

Commits on Aug 23, 2022

  1. Don't consider any flakes for a collection when no ecount set 

    The max subject id used by the database for a particular collection is set on
the db in the `ecounts` map as flakes in that collection are added to the
ledger. There's no value set in the map for that collection before any flakes in
that collection have been added. This has the effect of making the collection
have no upper limit during query processing, and flakes in any collection that
comes after the one in question are considered for analytical queries.

This patch changes the query engine so it doesn't load any flakes from
collections that don't have an ecount set because the ecount not being set means
there aren't any flakes in that collection.
    @zonotope
    zonotope committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    5e5c1e6 View commit details
    Browse the repository at this point in the history

  2. don't use if-not

    @zonotope
    zonotope committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    a41a527 View commit details
    Browse the repository at this point in the history