Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[example] add full page map example #201

Merged
merged 1 commit into from
Feb 15, 2020
Merged

[example] add full page map example #201

merged 1 commit into from
Feb 15, 2020

Conversation

tobrun
Copy link
Collaborator

@tobrun tobrun commented Jan 25, 2020

Example to reproduce #195

@tobrun tobrun self-assigned this Jan 25, 2020
@tobrun tobrun mentioned this pull request Jan 25, 2020
Open
m0nac0
m0nac0 approved these changes Jan 25, 2020
View reviewed changes
Copy link
Collaborator

@m0nac0 m0nac0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can reproduce #195 as I commented over there

@tobrun
Copy link
Collaborator Author

tobrun commented Feb 15, 2020

@m0nac0 wasn't able to reproduce that same issue fully but something related. I'm merging this example, lets fix #195 in a follow up PR.

@tobrun tobrun merged commit eeb130a into master Feb 15, 2020
@tobrun tobrun deleted the tvn-add-full-page-example branch February 15, 2020 08:43
Lobankovanastia pushed a commit to Lobankovanastia/flutter-mapbox-gl that referenced this pull request Feb 15, 2020
@tobrun
[example] add full page map example (flutter-mapbox-gl#201)
26cf2ad
andrea689 added a commit to andrea689/flutter-mapbox-gl that referenced this pull request Mar 13, 2020
@andrea689
Merge branch 'master' into av-web
8daf3df 
* master:
  Support setting map's content insets (flutter-mapbox-gl#215)
  Provide `onMapIdle` callback (flutter-mapbox-gl#214)
  [example] add full page map example (flutter-mapbox-gl#201)
  Fix missing location indicator on iOS (flutter-mapbox-gl#176)
  Returned a nil result so the future completes. (flutter-mapbox-gl#216)
  Update README: Access Tokens for self-hosted tiles (flutter-mapbox-gl#217)
  Change annotation priority (flutter-mapbox-gl#222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0nac0 m0nac0 m0nac0 approved these changes

Assignees

@tobrun tobrun

Labels
example flutter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobrun @m0nac0