Provide onMapIdle callback
#214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corresponding to `mapViewDidBecomeIdle` in the iOS SDK, this informs the application "that the map view is entering an idle state, and no more drawing will be necessary until new data is loaded or there is some interaction with the map." https://docs.mapbox.com/ios/api/maps/5.6.1/Protocols/MGLMapViewDelegate.html#/c:objc(pl)MGLMapViewDelegate(im)mapViewDidBecomeIdle: I have not provided an Android implementation as I am not set up to test one yet. I would do this later if it's still missing.
|
Awesome contribution @n8han! We will need the android equivalent of |
tobrun
approved these changes
Feb 15, 2020
Closed
Lobankovanastia
pushed a commit
to Lobankovanastia/flutter-mapbox-gl
that referenced
this pull request
Feb 15, 2020
Corresponding to `mapViewDidBecomeIdle` in the iOS SDK, this informs the application "that the map view is entering an idle state, and no more drawing will be necessary until new data is loaded or there is some interaction with the map." https://docs.mapbox.com/ios/api/maps/5.6.1/Protocols/MGLMapViewDelegate.html#/c:objc(pl)MGLMapViewDelegate(im)mapViewDidBecomeIdle: I have not provided an Android implementation as I am not set up to test one yet. I would do this later if it's still missing.
andrea689
added a commit
to andrea689/flutter-mapbox-gl
that referenced
this pull request
Mar 13, 2020
* master: Support setting map's content insets (flutter-mapbox-gl#215) Provide `onMapIdle` callback (flutter-mapbox-gl#214) [example] add full page map example (flutter-mapbox-gl#201) Fix missing location indicator on iOS (flutter-mapbox-gl#176) Returned a nil result so the future completes. (flutter-mapbox-gl#216) Update README: Access Tokens for self-hosted tiles (flutter-mapbox-gl#217) Change annotation priority (flutter-mapbox-gl#222)
|
@xing-zheng I just tried to implement this for Android, however the @tobrun Do you have an idea what's going on there? Reading the docs I think this is not the intended behavior for |
|
What branch is this in so I can test? I need this functionality for my Symbol updates on Zoom. |
That shouldn't be happening :) it can happen that onMapIdle is called for invalidation of tiles and that isn't visually seen be you but what you are describing seems to be a different bug. |
|
Does seem weird. I have been able to get |
n8han
added a commit
that referenced
this pull request
Oct 30, 2021
This is the android piece of PR #214. The listener `MapView.OnDidBecomeIdleListener` is less well documented than its iOS counterpart. We just have this to go on: > Interface definition for a callback to be invoked when the map has > entered the idle state. https://docs.mapbox.com/android/maps/api/9.6.1/com/mapbox/mapboxsdk/maps/MapView.OnDidBecomeIdleListener.html Fr the iOS framework method we have more detailed information: > Tells the delegate that the map view is entering an idle state, and no > more drawing will be necessary until new data is loaded or there is > some interaction with the map. > * No camera transitions are in progress > * All currently requested tiles have loaded > * All fade/transition animations have completed https://docs.mapbox.com/archive/ios/maps/api/5.6.1/Protocols/MGLMapViewDelegate.html#/c:objc(pl)MGLMapViewDelegate(im)mapViewDidBecomeIdle: After testing with these changes, it does seem to be the case that it is only invoked after the tiles are loaded. So I think this is the correct analogue for the iOS listener.
felix-ht
pushed a commit
that referenced
this pull request
Nov 2, 2021
This is the android piece of PR #214. The listener `MapView.OnDidBecomeIdleListener` is less well documented than its iOS counterpart. We just have this to go on: > Interface definition for a callback to be invoked when the map has > entered the idle state. https://docs.mapbox.com/android/maps/api/9.6.1/com/mapbox/mapboxsdk/maps/MapView.OnDidBecomeIdleListener.html Fr the iOS framework method we have more detailed information: > Tells the delegate that the map view is entering an idle state, and no > more drawing will be necessary until new data is loaded or there is > some interaction with the map. > * No camera transitions are in progress > * All currently requested tiles have loaded > * All fade/transition animations have completed https://docs.mapbox.com/archive/ios/maps/api/5.6.1/Protocols/MGLMapViewDelegate.html#/c:objc(pl)MGLMapViewDelegate(im)mapViewDidBecomeIdle: After testing with these changes, it does seem to be the case that it is only invoked after the tiles are loaded. So I think this is the correct analogue for the iOS listener.
n8han
added a commit
that referenced
this pull request
Nov 8, 2021
This is the android piece of PR #214. The listener `MapView.OnDidBecomeIdleListener` is less well documented than its iOS counterpart. We just have this to go on: > Interface definition for a callback to be invoked when the map has > entered the idle state. https://docs.mapbox.com/android/maps/api/9.6.1/com/mapbox/mapboxsdk/maps/MapView.OnDidBecomeIdleListener.html Fr the iOS framework method we have more detailed information: > Tells the delegate that the map view is entering an idle state, and no > more drawing will be necessary until new data is loaded or there is > some interaction with the map. > * No camera transitions are in progress > * All currently requested tiles have loaded > * All fade/transition animations have completed https://docs.mapbox.com/archive/ios/maps/api/5.6.1/Protocols/MGLMapViewDelegate.html#/c:objc(pl)MGLMapViewDelegate(im)mapViewDidBecomeIdle: After testing with these changes, it does seem to be the case that it is only invoked after the tiles are loaded. So I think this is the correct analogue for the iOS listener.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding to
mapViewDidBecomeIdlein the iOS SDK, this informs theapplication "that the map view is entering an idle state, and no more
drawing will be necessary until new data is loaded or there is some
interaction with the map."
https://docs.mapbox.com/ios/api/maps/5.6.1/Protocols/MGLMapViewDelegate.html#/c:objc(pl)MGLMapViewDelegate(im)mapViewDidBecomeIdle:
I have not provided an Android implementation as I am not set up to test
one yet. I would do this later if it's still missing.