Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in function name: FlutterDestoryWindow #56

Closed
wiertel opened this issue Mar 25, 2021 · 1 comment · Fixed by #59
Closed

typo in function name: FlutterDestoryWindow #56

wiertel opened this issue Mar 25, 2021 · 1 comment · Fixed by #59

Comments

@wiertel
Copy link
Member

wiertel commented Mar 25, 2021

FLUTTER_EXPORT void FlutterDestoryWindow(FlutterWindowControllerRef controller);

The "Destory" occurs 27 times in the repo. This one is part of public API and should probably be fixed. But I guess current name should continue to work to maintain compatibility.

@swift-kim
Copy link
Member

What a mistake. The change in flutter_tizen.h will not break anything as long as we simultaneously update https://github.com/flutter-tizen/flutter-tizen/blob/master/nuget/Tizen.Flutter.Embedding/Interop.cs as well. The change will definitely affect apps already created with the C++ language option (flutter-tizen create --tizen-language cpp, https://github.com/flutter-tizen/flutter-tizen/blob/master/templates/app/cpp/src/flutterapp.cc) but the native app type support is still experimental so it doesn't matter much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants