Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo and remove deprecated FlutterRotateWindow #59

Merged

Conversation

swift-kim
Copy link
Member

Fixes #56.

Will be followed by further fixes in Tizen.Flutter.Embedding and etc.

@swift-kim swift-kim requested review from wiertel and a team March 29, 2021 01:36
Copy link

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wiertel wiertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. This technically solves the reported issue.
The bad name can still be found in the repo, so I'm looking forward to the following changes :)

@swift-kim
Copy link
Member Author

@wiertel If you're referring to the occurrences of "FlutterDestoryWindow" in flutter-tizen/flutter-tizen, yes, I'll fix them as soon as this PR is merged and a new release is published.

@swift-kim swift-kim merged commit edddaf9 into flutter-tizen:flutter-2.0.1-tizen Mar 31, 2021
swift-kim added a commit that referenced this pull request Jun 7, 2021
* Fix typo FlutterDestoryWindow

* Remove FlutterRotateWindow
swift-kim added a commit that referenced this pull request Sep 27, 2021
* Fix typo FlutterDestoryWindow

* Remove FlutterRotateWindow
swift-kim added a commit that referenced this pull request Nov 14, 2021
* Fix typo FlutterDestoryWindow

* Remove FlutterRotateWindow
swift-kim added a commit that referenced this pull request Dec 9, 2021
* Fix typo FlutterDestoryWindow

* Remove FlutterRotateWindow
swift-kim added a commit that referenced this pull request Dec 17, 2021
* Fix typo FlutterDestoryWindow

* Remove FlutterRotateWindow
swift-kim added a commit that referenced this pull request Feb 7, 2022
* Fix typo FlutterDestoryWindow

* Remove FlutterRotateWindow
swift-kim added a commit that referenced this pull request Feb 11, 2022
* Fix typo FlutterDestoryWindow

* Remove FlutterRotateWindow
swift-kim added a commit that referenced this pull request May 12, 2022
* Fix typo FlutterDestoryWindow

* Remove FlutterRotateWindow
swift-kim added a commit that referenced this pull request Aug 5, 2022
* Fix typo FlutterDestoryWindow

* Remove FlutterRotateWindow
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
* Remove FML dependency on geometry, tessellator

* update readme
swift-kim added a commit that referenced this pull request Sep 1, 2022
* Fix typo FlutterDestoryWindow

* Remove FlutterRotateWindow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo in function name: FlutterDestoryWindow
4 participants