Minimum tizen shell for x64(pc) #125

bwikbs · 2021-06-23T23:33:40Z

This is for tizen shell for X64(PC)
This has the following goals:

Unit test for tizen embedder running on PC
A minimal shell for debugging (hopefully?)

Prerequisites

linux PC (I work on ubuntu 20.04)
efl (https://git.enlightenment.org/core/efl.git, https://www.enlightenment.org/docs/distros/start)

You can build it with the following command:

./flutter/tools/gn --unoptimized --enable-fontconfig --build-tizen-shell
ninja -C out/host_debug_unopt/
cd out/host_debug_unopt/
./flutter_tizen_unittests

./flutter/tools/gn --unoptimized --enable-fontconfig --build-tizen-shell --runtime-mode release
ninja -C out/host_release_unopt
cd out/host_release_unopt/
./flutter_tizen_unittests

To execute shell, the following tpkroot directory is required.

engine/src/out/host_debug_unopt/tpkroot$ ls -al
drwxrwxr-x  4 bwikbs bwikbs 4096  6월 29 09:15 .
drwx------ 11 bwikbs bwikbs 4096  6월 29 09:18 ..
drwxrwxr-x  2 bwikbs bwikbs 4096  6월 29 09:15 lib
drwxrwxr-x  3 bwikbs bwikbs 4096  6월 29 09:16 res

engine/src/out/host_debug_unopt/tpkroot$ ls lib
libapp.so

engine/src/out/host_debug_unopt/tpkroot$ ls res
flutter_assets  icudtl.dat

These files must be obtained from the x64 build on a different port.

You can run x64 shell with following command

./flutter_tizen_shell --tpkroot=./tpkroot/ --width=500 --height=600

Here is sample tpkroot for your convenience.
tpkroot.zip
This is a Hello World sample,
Just Upack it to the path where the shell executable file is located.

shell/platform/BUILD.gn

bbrto21

I met this error

[3850/5348] CXX obj/third_party/skia/src/core/skia.SkBlitter_ARGB32.o
FAILED: obj/third_party/skia/src/core/skia.SkBlitter_ARGB32.o 
../../buildtools/linux-x64/clang/bin/clang++ -MD -MF obj/third_party/skia/src/core/skia.SkBlitter_ARGB32.o.d -DSK_HAS_ANDROID_CODEC -DUSE_OPENSSL=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_AVAILABILITY=1 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -D_DEBUG -D_GLIBCXX_DEBUG=1 -DSK_R32_SHIFT=16 -DSK_DISABLE_REDUCE_OPLIST_SPLITTING -DSK_ENABLE_DUMP_GPU -DSK_DISABLE_AAA -DSK_PARAGRAPH_LIBTXT_SPACES_RESOLUTION -DSK_PARAGRAPH_ROUND_POSITION -DSK_DISABLE_LEGACY_SHADERCONTEXT -DSK_DISABLE_LOWP_RASTER_PIPELINE -DSK_FORCE_RASTER_PIPELINE_BLITTER -DSK_GL -DSK_DISABLE_EFFECT_DESERIALIZATION -DSK_GAMMA_APPLY_TO_A8 -DSKIA_IMPLEMENTATION=1 -DSK_GL -DSK_ENABLE_DUMP_GPU -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_CODEC_DECODES_PNG -DSK_ENCODE_PNG -DSK_CODEC_DECODES_WEBP -DSK_ENCODE_WEBP -DSK_HAS_WUFFS_LIBRARY -I../.. -Igen -I../../third_party/libcxx/include -I../../third_party/libcxxabi/include -I../../third_party/libcxxabi/include -I../../third_party/skia -I../../third_party/fontconfig/src -fno-strict-aliasing -fstack-protector --param=ssp-buffer-size=4 -m64 -march=x86-64 -fPIC -pipe -pthread -fcolor-diagnostics -Wall -Wextra -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-implicit-int-float-conversion -Wno-c99-designator -Wno-deprecated-copy -Wno-range-loop-construct -fvisibility=hidden --sysroot=/home/boram/Work/f-project/engine/src/build/linux/debian_sid_amd64-sysroot -Wstring-conversion -Wnewline-eof -O0 -g2 -fvisibility-inlines-hidden -std=c++17 -fno-rtti -nostdinc++ -nostdinc++ -fno-exceptions   -c ../../third_party/skia/src/core/SkBlitter_ARGB32.cpp -o obj/third_party/skia/src/core/skia.SkBlitter_ARGB32.o
In file included from ../../third_party/skia/src/core/SkBlitter_ARGB32.cpp:10:
../../third_party/skia/include/private/SkVx.h:459:43: error: AVX vector return of type 'VExt<16, unsigned short>' (vector of 16 'unsigned short' values) without 'avx' enabled changes the ABI [-Werror,-Wpsabi]
    return to_vec(__builtin_convertvector(to_vext(src), VExt<N,D>))

shell/platform/tizen/channels/localization_channel.cc

shell/platform/tizen/flutter_tizen_shell.cc

shell/platform/tizen/channels/platform_channel.cc

shell/platform/tizen/channels/text_input_channel.cc

bbrto21 · 2021-06-30T03:58:41Z

You add many X64_SHELL pairs of each module now to run test.
If each module has a more simplified implementation pair and uses it for testing, what does these tests mean?

bwikbs · 2021-06-30T04:27:10Z

You add many X64_SHELL pairs of each module now to run test.
If each module has a more simplified implementation pair and uses it for testing, what does these tests mean?

The current work is to create a stub of the module for x64 build.
I think that from now on, if we want to add tests for the module, appropriate mock should be added with TC at the same time.

bwikbs · 2021-06-30T04:31:05Z

I met this error

[3850/5348] CXX obj/third_party/skia/src/core/skia.SkBlitter_ARGB32.o
FAILED: obj/third_party/skia/src/core/skia.SkBlitter_ARGB32.o 
../../buildtools/linux-x64/clang/bin/clang++ -MD -MF obj/third_party/skia/src/core/skia.SkBlitter_ARGB32.o.d -DSK_HAS_ANDROID_CODEC -DUSE_OPENSSL=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_AVAILABILITY=1 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -D_DEBUG -D_GLIBCXX_DEBUG=1 -DSK_R32_SHIFT=16 -DSK_DISABLE_REDUCE_OPLIST_SPLITTING -DSK_ENABLE_DUMP_GPU -DSK_DISABLE_AAA -DSK_PARAGRAPH_LIBTXT_SPACES_RESOLUTION -DSK_PARAGRAPH_ROUND_POSITION -DSK_DISABLE_LEGACY_SHADERCONTEXT -DSK_DISABLE_LOWP_RASTER_PIPELINE -DSK_FORCE_RASTER_PIPELINE_BLITTER -DSK_GL -DSK_DISABLE_EFFECT_DESERIALIZATION -DSK_GAMMA_APPLY_TO_A8 -DSKIA_IMPLEMENTATION=1 -DSK_GL -DSK_ENABLE_DUMP_GPU -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_CODEC_DECODES_PNG -DSK_ENCODE_PNG -DSK_CODEC_DECODES_WEBP -DSK_ENCODE_WEBP -DSK_HAS_WUFFS_LIBRARY -I../.. -Igen -I../../third_party/libcxx/include -I../../third_party/libcxxabi/include -I../../third_party/libcxxabi/include -I../../third_party/skia -I../../third_party/fontconfig/src -fno-strict-aliasing -fstack-protector --param=ssp-buffer-size=4 -m64 -march=x86-64 -fPIC -pipe -pthread -fcolor-diagnostics -Wall -Wextra -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-implicit-int-float-conversion -Wno-c99-designator -Wno-deprecated-copy -Wno-range-loop-construct -fvisibility=hidden --sysroot=/home/boram/Work/f-project/engine/src/build/linux/debian_sid_amd64-sysroot -Wstring-conversion -Wnewline-eof -O0 -g2 -fvisibility-inlines-hidden -std=c++17 -fno-rtti -nostdinc++ -nostdinc++ -fno-exceptions   -c ../../third_party/skia/src/core/SkBlitter_ARGB32.cpp -o obj/third_party/skia/src/core/skia.SkBlitter_ARGB32.o
In file included from ../../third_party/skia/src/core/SkBlitter_ARGB32.cpp:10:
../../third_party/skia/include/private/SkVx.h:459:43: error: AVX vector return of type 'VExt<16, unsigned short>' (vector of 16 'unsigned short' values) without 'avx' enabled changes the ABI [-Werror,-Wpsabi]
    return to_vec(__builtin_convertvector(to_vext(src), VExt<N,D>))

Sorry.. I forgot to tell you.. you have to revert the following diff.

bwikbs@rat5:~/workspace/flutter-tizen/engine/src$ git diff
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index e88c060..be4abae 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -688,11 +688,11 @@ if (is_win) {
       "-Wno-implicit-int-float-conversion",
       "-Wno-c99-designator",
       # Needed for compiling Skia with clang-12
-      "-Wno-psabi",
+      # "-Wno-psabi",
     ]
     if (!is_fuchsia) {
       default_warning_flags += [
-        "-Wno-non-c-typedef-for-linkage",
+        # "-Wno-non-c-typedef-for-linkage",
         "-Wno-deprecated-copy",
         "-Wno-range-loop-construct",
       ]

bbrto21 · 2021-06-30T04:38:38Z

The current work is to create a stub of the module for x64 build.

What is your final goal? Is X64_SHELL an intermediate step for testing on devices? If not, are you only considering the desktop environment?

bwikbs · 2021-06-30T05:05:07Z

What is your final goal? Is X64_SHELL an intermediate step for testing on devices? If not, are you only considering the desktop environment?

In conclusion, yes(At least that's my plan...)
The reason I started this was because I wanted to have an efficient debugging environment (I was thinking at font issue time!) & It was a unit test environment of newly implemented api in embedder.

swift-kim

You might take a look at the gMock documentation (http://google.github.io/googletest/gmock_for_dummies.html) if you haven't.

shell/platform/tizen/BUILD.gn

shell/platform/tizen/flutter_tizen_engine_test.cc

swift-kim · 2021-07-02T02:41:25Z

Linking failed on my laptop.

$ ninja -C out/host_debug
ninja: Entering directory `out/host_debug'
[1/1] Regenerating ninja files
[5369/5654] SOLINK ./libflutter_tizen_common.so
FAILED: libflutter_tizen_common.so libflutter_tizen_common.so.TOC
../../buildtools/linux-x64/clang/bin/clang++ -shared -Wl,--fatal-warnings -m64 -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -pthread --sysroot=/home/swift/Git/flutter/engine/src/build/linux/debian_sid_amd64-sysroot -L/home/swift/Git/flutter/engine/src/build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu\ -Wl,-rpath-link=/home/swift/Git/flutter/engine/src/build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu\ -L/home/swift/Git/flutter/engine/src/build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu\ -Wl,-rpath-link=/home/swift/Git/flutter/engine/src/build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu\ -L/home/swift/Git/flutter/engine/src/build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu\ -Wl,-rpath-link=/home/swift/Git/flutter/engine/src/build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-O2 -Wl,--gc-sections -Wl,--as-needed -Wl,-rpath,\$ORIGIN -L/usr/local/lib -L.  -o ./libflutter_tizen_common.so -Wl,--build-id=sha1 -Wl,-soname=libflutter_tizen_common.so @./libflutter_tizen_common.so.rsp && { ../../buildtools/linux-x64/clang/bin/llvm-readelf -d ./libflutter_tizen_common.so | grep SONAME ; ../../buildtools/linux-x64/clang/bin/llvm-nm -gD -f posix ./libflutter_tizen_common.so | cut -f1-2 -d' '; } > ./libflutter_tizen_common.so.tmp && if ! cmp -s ./libflutter_tizen_common.so.tmp ./libflutter_tizen_common.so.TOC; then mv ./libflutter_tizen_common.so.tmp ./libflutter_tizen_common.so.TOC; fi
ld.lld: error: unable to find library -lecore
ld.lld: error: unable to find library -lecore_imf
ld.lld: error: unable to find library -lecore_input
ld.lld: error: unable to find library -leina
ld.lld: error: unable to find library -lecore_evas
ld.lld: error: unable to find library -lelementary
ld.lld: error: unable to find library -levas
clang-13: error: linker command failed with exit code 1 (use -v to see invocation)

In my case EFL libs have been installed to /usr/local/lib/x86_64-linux-gnu/ but not /usr/local/lib/ (I didn't change any configuration but just followed the install guide you provided). I worked around by modifying lib_dirs of tizen/BUILD.gn temporarily but what would be a correct way to deal with this problem?

bwikbs · 2021-07-02T03:17:55Z

In my case EFL libs have been installed to /usr/local/lib/x86_64-linux-gnu/ but not /usr/local/lib/ (I didn't change any configuration but just followed the install guide you provided).

I really didn't expect that.. 😢 I guess we should use something (like pkg-config) here.

shell/platform/tizen/BUILD.gn

shell/platform/tizen/channels/localization_channel.cc

swift-kim · 2021-07-02T05:44:17Z

shell/platform/tizen/channels/localization_channel.cc

 #include <utils_i18n.h>
+#else


I think separating implementation files for device/desktop shells makes the code cleaner and easier to understand: https://github.com/swift-kim/engine/commits/pr/125.

Thanks for the suggestion. I think that's a good idea.

Now, It's applied!

shell/platform/tizen/flutter_tizen_engine_test.cc

shell/platform/tizen/flutter_tizen_shell.cc

bwikbs · 2021-07-05T01:56:44Z

In my case EFL libs have been installed to /usr/local/lib/x86_64-linux-gnu/ but not /usr/local/lib/ (I didn't change any configuration but just followed the install guide you provided).

I really didn't expect that.. I guess we should use something (like pkg-config) here.

I just found out that the path /usr/local/lib/x86_64-linux-gnu is correct. /usr/local/lib/ is what I had installed before.

Signed-off-by: MuHong Byun <mh.byun@samsung.com> Use enable_desktop_embeddings instead of embedder_for_pc Signed-off-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Swift Kim <swift.kim@samsung.com> Add flutter_tizen_engine TC Signed-off-by: MuHong Byun <mh.byun@samsung.com> Add basic shell for test Signed-off-by: MuHong Byun <mh.byun@samsung.com> Introduce mock_engine for unittest * copied from linux port ('/shell/platform/linux/testing/mock_engine.cc') Signed-off-by: MuHong Byun <mh.byun@samsung.com> Apply review's comment Signed-off-by: MuHong Byun <mh.byun@samsung.com> Code clean-up && Apply review's comment Signed-off-by: MuHong Byun <mh.byun@samsung.com> Clean up shell/platform/tizen/BUILD.gn Signed-off-by: MuHong Byun <mh.byun@samsung.com> Clean up shell/platform/tizen/BUILD.gn #2 Signed-off-by: MuHong Byun <mh.byun@samsung.com> Add EvasGL Helper for x64 shell build * This file is the same file as Evas_GL_GLES3_Helpers.h in tizen. Signed-off-by: MuHong Byun <mh.byun@samsung.com> Fix minor thing * Change ecore lib path at X64 shell * Refactor log function dummy * Apply review's comment Signed-off-by: MuHong Byun <mh.byun@samsung.com>

…op shell depdendencies

* Add log stub Signed-off-by: MuHong Byun <mh.byun@samsung.com>

swift-kim

Minor points. Thank you.

shell/platform/tizen/flutter_tizen_shell.cc

shell/platform/tizen/testing/mock_engine.cc

shell/platform/tizen/tizen_event_loop.cc

shell/platform/tizen/tizen_log.h

shell/platform/tizen/tizen_renderer_ecore_wl2.h

shell/platform/tizen/tizen_vsync_waiter.h

swift-kim · 2021-07-05T03:18:36Z

shell/platform/tizen/tizen_renderer_evas_gl.cc

+#ifndef __X64_SHELL__
  gl_context_ =
      evas_gl_context_version_create(evas_gl_, NULL, EVAS_GL_GLES_3_X);
  gl_resource_context_ =
      evas_gl_context_version_create(evas_gl_, gl_context_, EVAS_GL_GLES_3_X);
-
+#endif


Does this mean the desktop shell always falls back to EVAS_GL_GLES_2_X?

That's right. I don't know if this is just my problem or evasgl problem... 3.0 doesn't work.

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

bbrto21 · 2021-07-05T07:01:38Z

efl (https://git.enlightenment.org/core/efl.git, https://www.enlightenment.org/docs/distros/start)

Which version should I use?

bwikbs · 2021-07-05T07:07:00Z

efl (https://git.enlightenment.org/core/efl.git, https://www.enlightenment.org/docs/distros/start)

Which version should I use?

In my case, It's v1.25.1

bbrto21 · 2021-07-05T07:57:17Z

./flutter_tizen_shell --tpkroot=./tpkroot/ --width=500 --height=600

I got this error

Launching a Flutter application...
embedder.cc (939): 'FlutterEngineInitialize' returned 'kInvalidArguments'. Not running in AOT mode but could not resolve the kernel binary.
: %s: %s(%d) > FlutterEngineRun Failure! result: %d(2204910) > FlutterEngineRun Failure! result: 2226933: %s: %s(%d) > Failed to run the Flutter engine.(2159055) > Failed to run the Flutter engine.Could not launch a Flutter application.
Segmentation fault (core dumped)

bwikbs · 2021-07-05T08:06:40Z

./flutter_tizen_shell --tpkroot=./tpkroot/ --width=500 --height=600

I got this error

Launching a Flutter application...
embedder.cc (939): 'FlutterEngineInitialize' returned 'kInvalidArguments'. Not running in AOT mode but could not resolve the kernel binary.
: %s: %s(%d) > FlutterEngineRun Failure! result: %d(2204910) > FlutterEngineRun Failure! result: 2226933: %s: %s(%d) > Failed to run the Flutter engine.(2159055) > Failed to run the Flutter engine.Could not launch a Flutter application.
Segmentation fault (core dumped)

Now. Updated description. Refer to it and run it.

bbrto21

To achieve the purpose of this PR, It would be great if you make sure that show the symbols when debugging.

Reading symbols from ./flutter_tizen_shell...
(No debugging symbols found in ./flutter_tizen_shell)

shell/platform/tizen/flutter_tizen_engine_unittest.cc

shell/platform/tizen/tizen_log_stub.cc

bbrto21 · 2021-07-05T10:17:53Z

shell/platform/tizen/tizen_evas_gl_helper.h

+// This file has same content as tizen's file(Evas_GL_GLES3_Helpers.h).
+// https://docs.tizen.org/application/native/api/mobile/6.0/group__Evas__GL__GLES3__Helpers.html


I'm not sure, but...I doubt this is for the best. Do we have to do this?
(If I'm not mistaken... is this change added recently?)

Well.. I didn't quite understand the your point...
Does your intention mean we shouldn't use that macro in renderers?
I think that this macro could be used because it would improve readability and have no dependencies.
Let me know your concerns & I'll check it!

My intention is that I want to avoid keeping a copy of Evans_GLES3_Helpers.h in engine source tree.
I wonder what other people think about this. @flutter-tizen/maintainers

It is ideal to remove the file from our source tree. Is there any way to do so?

It is ideal to remove the file from our source tree. Is there any way to do so?

Remove macro at evasgl renderer? @bbrto21 said to include the path of the tizen sdk... To be honest, I don't know...
IMO, We should make a choice between duplicate or removing macro. (I can't think of any good ideas... 😢 )

bwikbs · 2021-07-05T22:28:16Z

To achieve the purpose of this PR, It would be great if you make sure that show the symbols when debugging.
Reading symbols from ./flutter_tizen_shell...
(No debugging symbols found in ./flutter_tizen_shell)

You can find what you want at this path exe.unstripped (Is this what you intended?)

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

bwikbs · 2021-07-06T05:03:49Z

Since you explained that the purpose of this PR is to make debugging easier, I didn't think the missing symbols were your intention. also you are proposing a new build option combinations, so even if we don't use unstripped, I've believed you should configure the build to have symbols without being optimized for this.

I guess you & I aren't on same page. I simply wanted to debug it with eclipse on my desktop pc. 😄
Anyway, I'll take a look and figure out if it's simple, then I apply it. Otherwise, like you said, I'll wait for someone else to do it.

swift-kim · 2021-07-06T05:26:30Z

@bbrto21 From my understanding, the purpose of the x64 shell is not limited to debugging/testing, but ideally it's intended for running general types of applications (including debuggee and unit tests) on desktop. So the default behavior should be stripping out symbols (especially when the shell is built in release mode).

swift-kim

I think it's enough for now. Thanks.

swift-kim · 2021-07-06T06:01:11Z

shell/platform/common/BUILD.gn

@@ -3,6 +3,7 @@
 # found in the LICENSE file.

 import("//flutter/common/config.gni")
+import("//flutter/shell/platform/config.gni")


Unused import.

* Enable x64(pc) build for tizen shell Signed-off-by: MuHong Byun <mh.byun@samsung.com> Use enable_desktop_embeddings instead of embedder_for_pc Signed-off-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Swift Kim <swift.kim@samsung.com> Add flutter_tizen_engine TC Signed-off-by: MuHong Byun <mh.byun@samsung.com> Add basic shell for test Signed-off-by: MuHong Byun <mh.byun@samsung.com> Introduce mock_engine for unittest * copied from linux port ('/shell/platform/linux/testing/mock_engine.cc') Signed-off-by: MuHong Byun <mh.byun@samsung.com> Apply review's comment Signed-off-by: MuHong Byun <mh.byun@samsung.com> Code clean-up && Apply review's comment Signed-off-by: MuHong Byun <mh.byun@samsung.com> Clean up shell/platform/tizen/BUILD.gn Signed-off-by: MuHong Byun <mh.byun@samsung.com> Clean up shell/platform/tizen/BUILD.gn #2 Signed-off-by: MuHong Byun <mh.byun@samsung.com> Add EvasGL Helper for x64 shell build * This file is the same file as Evas_GL_GLES3_Helpers.h in tizen. Signed-off-by: MuHong Byun <mh.byun@samsung.com> Fix minor thing * Change ecore lib path at X64 shell * Refactor log function dummy * Apply review's comment Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Add stubs for LocalizationChannel and PlatformChannel * Add SettingsChannel stub * Remove ExternalTexturePixelGL and ExternalTextureSurfaceGL from destkop shell depdendencies * Fix minor thing * Add log stub Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Apply review's comment Signed-off-by: MuHong Byun <mh.byun@samsung.com> * Apply review's comment #2 Signed-off-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Swift Kim <swift.kim@samsung.com>

* Enable x64 (PC) build for tizen shell Add flutter_tizen_engine TC Add basic shell for test Introduce mock_engine for unittest Clean up shell/platform/tizen/BUILD.gn Add EvasGL Helper for x64 shell build * This file is the same file as Evas_GL_GLES3_Helpers.h in tizen. * Add stubs for LocalizationChannel and PlatformChannel * Add SettingsChannel stub * Remove ExternalTexturePixelGL and ExternalTextureSurfaceGL from destkop shell depdendencies * Add log stub * Apply review's comment Signed-off-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Swift Kim <swift.kim@samsung.com>

* Enable x64 (PC) build for tizen shell Add flutter_tizen_engine TC Add basic shell for test Introduce mock_engine for unittest Clean up shell/platform/tizen/BUILD.gn Add EvasGL Helper for x64 shell build * Add stubs for LocalizationChannel and PlatformChannel * Add SettingsChannel stub * Remove ExternalTexturePixelGL and ExternalTextureSurfaceGL from destkop shell depdendencies * Add log stub Signed-off-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Swift Kim <swift.kim@samsung.com>

bwikbs changed the title ~~Enable x64(pc) build for tizen shell~~ Minimum tizen shell for x64(pc) Jun 23, 2021

bwikbs force-pushed the x64_shell branch from 010d27a to c112f7e Compare June 23, 2021 23:44

swift-kim reviewed Jun 24, 2021

View reviewed changes

shell/platform/BUILD.gn Show resolved Hide resolved

bwikbs force-pushed the x64_shell branch 4 times, most recently from e42a022 to 1b27461 Compare June 29, 2021 07:50

bwikbs marked this pull request as ready for review June 30, 2021 00:07

bbrto21 reviewed Jun 30, 2021

View reviewed changes

bwikbs force-pushed the x64_shell branch 2 times, most recently from e375b8c to 1402c64 Compare July 1, 2021 00:40

swift-kim reviewed Jul 1, 2021

View reviewed changes

shell/platform/tizen/BUILD.gn Outdated Show resolved Hide resolved

shell/platform/tizen/BUILD.gn Outdated Show resolved Hide resolved

shell/platform/tizen/flutter_tizen_engine_test.cc Outdated Show resolved Hide resolved

bwikbs force-pushed the x64_shell branch from 332554b to 50be8b1 Compare July 1, 2021 10:15

swift-kim reviewed Jul 2, 2021

View reviewed changes

swift-kim mentioned this pull request Jul 2, 2021

Add FlutterDesktopWindowProperties to the public API #133

Merged

bwikbs force-pushed the x64_shell branch from 865ee6b to d1f0815 Compare July 5, 2021 03:24

bwikbs and others added 5 commits July 5, 2021 12:32

Add stubs for LocalizationChannel and PlatformChannel

484a20f

Add SettingsChannel stub

01650b7

Remove ExternalTexturePixelGL and ExternalTextureSurfaceGL from destk…

058f962

…op shell depdendencies

Fix minor thing

553bdcc

* Add log stub Signed-off-by: MuHong Byun <mh.byun@samsung.com>

bwikbs force-pushed the x64_shell branch from d1f0815 to 553bdcc Compare July 5, 2021 04:27

swift-kim reviewed Jul 5, 2021

View reviewed changes

Apply review's comment

719fd24

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

bbrto21 reviewed Jul 5, 2021

View reviewed changes

Apply review's comment #2

b7f4c43

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

This comment has been minimized.

Sign in to view

swift-kim approved these changes Jul 6, 2021

View reviewed changes

bbrto21 approved these changes Jul 6, 2021

View reviewed changes

bbrto21 merged commit 8f98253 into flutter-tizen:flutter-2.2.1-tizen Jul 6, 2021

swift-kim mentioned this pull request Jul 20, 2021

Support dart entrypoint #149

Merged

swift-kim mentioned this pull request Jul 28, 2021

Add support for incoming application control #154

Merged

swift-kim pushed a commit that referenced this pull request Sep 1, 2022

No newline in depfile output, which seems to confuse ninja (#125)

533b86d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minimum tizen shell for x64(pc) #125

Minimum tizen shell for x64(pc) #125

bwikbs commented Jun 23, 2021 •

edited

Loading

bbrto21 left a comment

bbrto21 commented Jun 30, 2021 •

edited

Loading

bwikbs commented Jun 30, 2021

bwikbs commented Jun 30, 2021

bbrto21 commented Jun 30, 2021

bwikbs commented Jun 30, 2021

swift-kim left a comment

swift-kim commented Jul 2, 2021

bwikbs commented Jul 2, 2021

swift-kim Jul 2, 2021 •

edited

Loading

bwikbs Jul 5, 2021

bwikbs Jul 5, 2021

bwikbs commented Jul 5, 2021

swift-kim left a comment

swift-kim Jul 5, 2021

bwikbs Jul 5, 2021

bbrto21 commented Jul 5, 2021

bwikbs commented Jul 5, 2021

bbrto21 commented Jul 5, 2021

bwikbs commented Jul 5, 2021

bbrto21 left a comment

bbrto21 Jul 5, 2021 •

edited

Loading

bwikbs Jul 5, 2021

bbrto21 Jul 6, 2021 •

edited

Loading

swift-kim Jul 6, 2021

bwikbs Jul 6, 2021

bwikbs commented Jul 5, 2021

This comment has been minimized.

bwikbs commented Jul 6, 2021

swift-kim commented Jul 6, 2021

swift-kim left a comment

swift-kim Jul 6, 2021

		// This file has same content as tizen's file(Evas_GL_GLES3_Helpers.h).
		// https://docs.tizen.org/application/native/api/mobile/6.0/group__Evas__GL__GLES3__Helpers.html

Minimum tizen shell for x64(pc) #125

Minimum tizen shell for x64(pc) #125

Conversation

bwikbs commented Jun 23, 2021 • edited Loading

bbrto21 left a comment

Choose a reason for hiding this comment

bbrto21 commented Jun 30, 2021 • edited Loading

bwikbs commented Jun 30, 2021

bwikbs commented Jun 30, 2021

bbrto21 commented Jun 30, 2021

bwikbs commented Jun 30, 2021

swift-kim left a comment

Choose a reason for hiding this comment

swift-kim commented Jul 2, 2021

bwikbs commented Jul 2, 2021

swift-kim Jul 2, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwikbs commented Jul 5, 2021

swift-kim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bbrto21 commented Jul 5, 2021

bwikbs commented Jul 5, 2021

bbrto21 commented Jul 5, 2021

bwikbs commented Jul 5, 2021

bbrto21 left a comment

Choose a reason for hiding this comment

bbrto21 Jul 5, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bbrto21 Jul 6, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwikbs commented Jul 5, 2021

This comment has been minimized.

bwikbs commented Jul 6, 2021

swift-kim commented Jul 6, 2021

swift-kim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bwikbs commented Jun 23, 2021 •

edited

Loading

bbrto21 commented Jun 30, 2021 •

edited

Loading

swift-kim Jul 2, 2021 •

edited

Loading

bbrto21 Jul 5, 2021 •

edited

Loading

bbrto21 Jul 6, 2021 •

edited

Loading