Add FlutterDesktopWindowProperties to the public API #133

swift-kim · 2021-06-30T01:17:08Z

Add FlutterProjectBundle and refactor similarly to the Windows embedder.
Allow relative paths as values of assets_path, icu_data_path, and aot_library_path.
Add FlutterDesktopWindowProperties to flutter_tizen.h. This might be used in the future.

Caveats:

If width or height in FlutterDesktopWindowProperties is set to non-zero, it is assumed that the screen is not resizable. Attempting to resize or rotate the screen is an undefined behavior.

This depends on #131 and should be rebased after #131 is merged.

swift-kim · 2021-06-30T01:53:42Z

The relative path thing doesn't work in case of the .NET app type because the executable path resolves to /usr/bin/dotnet-launcher but not the app's main assembly (bin/Runner.dll) path.

edit) It can't be applied to the native app case either because the executable path appears to be /usr/bin/launchpad-loader but not bin/runner in the same manner.

swift-kim · 2021-07-02T02:48:42Z

I just removed the relative path support to avoid any confusion.

swift-kim · 2021-07-02T11:44:18Z

I'll rebase and resolve any conflict when #125 is merged. You can still review the change.

shell/platform/tizen/flutter_tizen_engine.h

xuelian-bai · 2021-07-07T01:13:03Z

shell/platform/tizen/tizen_renderer_ecore_wl2.cc

@@ -233,20 +234,20 @@ uintptr_t TizenRendererEcoreWl2::GetWindowId() {

 bool TizenRendererEcoreWl2::InitializeRenderer() {
  int32_t width, height;
-  if (!SetupDisplay(width, height)) {
-    FT_LOGE("SetupDisplay fail");
+  if (!SetupDisplay(&width, &height)) {


if you use initial_geometry, maybe you don't really need this "width" and "height".

As you can see in the documentation of FlutterDesktopWindowProperties, if the width and height are not provided by the app explicitly, the values are obtained from the current display just as usual.

shell/platform/tizen/flutter_tizen_engine_unittest.cc

bwikbs · 2021-07-08T02:07:30Z

shell/platform/tizen/flutter_tizen.cc

-  if (!engine->RunEngine(engine_properties)) {
+  flutter::FlutterProjectBundle project(engine_properties);
+  auto engine = std::make_unique<flutter::FlutterTizenEngine>(project);
+  if (window_properties.headed) {


I love this part! ❤️ It's much more intuitive. Thanks

bwikbs

Thanks It's pretty cool!

bbrto21

LGTM!

shell/platform/tizen/flutter_tizen_engine.h

bbrto21 · 2021-07-08T04:41:40Z

shell/platform/tizen/flutter_tizen_shell.cc

    return true;
  }

  void OnTerminate() {
-    printf("Shutting down the application...");
+    printf("Shutting down the application...\n");


What do you think about modifying it as below and using the log macros?

--- a/shell/platform/tizen/tizen_log_stub.cc +++ b/shell/platform/tizen/tizen_log_stub.cc @@ -19,7 +19,7 @@ namespace flutter { void SetMinLoggingLevel(log_priority p){}; log_priority GetMinLoggingLevel() { - return DLOG_ERROR; + return DLOG_DEBUG; };

~~As we're already passing --verbose-logging as an engine argument, there's no need to change GetMinLoggingLevel.~~

I don't think it makes sense to use printf in OnCretae and FT_LOGI in OnTerminate. I think it's better to leave them as they are or remove both from OnCreate and OnTerminate.

Yes, you can remove both and it's better than the current.

yes, we can remove both and it is nice rather then as it is

* Refactor using FlutterProjectBundle * Unsupport relative paths * Reland the support for relative paths * Add FlutterDesktopWindowProperties to the public API * Document undocumented public APIs * Rebase and resolve conflicts * Enable FlutterTizenEngineTest.Run_Twice * Add documentation

…rms. (#133)

* Refactor using FlutterProjectBundle * Unsupport relative paths * Reland the support for relative paths * Add FlutterDesktopWindowProperties to the public API * Document undocumented public APIs * Rebase and resolve conflicts * Enable FlutterTizenEngineTest.Run_Twice * Add documentation

swift-kim mentioned this pull request Jun 30, 2021

Support dart entrypoint #111

Closed

swift-kim force-pushed the project-bundle branch from 18f2c9c to e27569b Compare July 2, 2021 02:20

swift-kim requested a review from a team July 2, 2021 02:20

swift-kim mentioned this pull request Jul 2, 2021

Minimum tizen shell for x64(pc) #125

Merged

bbrto21 reviewed Jul 5, 2021

View reviewed changes

shell/platform/tizen/flutter_tizen_engine.h Outdated Show resolved Hide resolved

swift-kim changed the title ~~Refactor using FlutterProjectBundle~~ Add FlutterDesktopWindowProperties to the public API Jul 6, 2021

swift-kim mentioned this pull request Jul 6, 2021

Add support for FlutterDesktopWindowProperties flutter-tizen/flutter-tizen#159

Merged

swift-kim added 5 commits July 6, 2021 17:09

Refactor using FlutterProjectBundle

a385454

Unsupport relative paths

0537059

Reland the support for relative paths

c4ba3de

Add FlutterDesktopWindowProperties to the public API

2315735

Document undocumented public APIs

64f3211

xuelian-bai reviewed Jul 7, 2021

View reviewed changes

Rebase and resolve conflicts

2e3cbb9

swift-kim force-pushed the project-bundle branch from 921be42 to 2e3cbb9 Compare July 8, 2021 01:43

bwikbs reviewed Jul 8, 2021

View reviewed changes

shell/platform/tizen/flutter_tizen_engine_unittest.cc Outdated Show resolved Hide resolved

bwikbs reviewed Jul 8, 2021

View reviewed changes

shell/platform/tizen/flutter_tizen_engine_unittest.cc Outdated Show resolved Hide resolved

bwikbs reviewed Jul 8, 2021

View reviewed changes

bwikbs mentioned this pull request Jul 8, 2021

Update flutter_tizen_engine_unittest #135

Closed

bwikbs approved these changes Jul 8, 2021

View reviewed changes

Enable FlutterTizenEngineTest.Run_Twice

04de468

swift-kim force-pushed the project-bundle branch from 601a517 to 04de468 Compare July 8, 2021 04:21

bbrto21 approved these changes Jul 8, 2021

View reviewed changes

Add documentation

0bd5307

swift-kim merged commit 39fd66f into flutter-tizen:flutter-2.2.1-tizen Jul 8, 2021

swift-kim mentioned this pull request Jul 9, 2021

Is there any way to make partial window app? flutter-tizen/flutter-tizen#161

Closed

swift-kim pushed a commit that referenced this pull request Sep 1, 2022

Allow building targets that do not create metal shaders on all platfo…

3bc1f33

…rms. (#133)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add FlutterDesktopWindowProperties to the public API #133

Add FlutterDesktopWindowProperties to the public API #133

swift-kim commented Jun 30, 2021 •

edited

Loading

swift-kim commented Jun 30, 2021 •

edited

Loading

swift-kim commented Jul 2, 2021

swift-kim commented Jul 2, 2021

xuelian-bai Jul 7, 2021

swift-kim Jul 7, 2021

bwikbs Jul 8, 2021

bwikbs left a comment •

edited

Loading

bbrto21 left a comment

bbrto21 Jul 8, 2021

swift-kim Jul 8, 2021 •

edited

Loading

bbrto21 Jul 8, 2021

bbrto21 Jul 8, 2021

Add FlutterDesktopWindowProperties to the public API #133

Add FlutterDesktopWindowProperties to the public API #133

Conversation

swift-kim commented Jun 30, 2021 • edited Loading

swift-kim commented Jun 30, 2021 • edited Loading

swift-kim commented Jul 2, 2021

swift-kim commented Jul 2, 2021

xuelian-bai Jul 7, 2021

Choose a reason for hiding this comment

swift-kim Jul 7, 2021

Choose a reason for hiding this comment

bwikbs Jul 8, 2021

Choose a reason for hiding this comment

bwikbs left a comment • edited Loading

Choose a reason for hiding this comment

bbrto21 left a comment

Choose a reason for hiding this comment

bbrto21 Jul 8, 2021

Choose a reason for hiding this comment

swift-kim Jul 8, 2021 • edited Loading

Choose a reason for hiding this comment

bbrto21 Jul 8, 2021

Choose a reason for hiding this comment

bbrto21 Jul 8, 2021

Choose a reason for hiding this comment

swift-kim commented Jun 30, 2021 •

edited

Loading

swift-kim commented Jun 30, 2021 •

edited

Loading

bwikbs left a comment •

edited

Loading

swift-kim Jul 8, 2021 •

edited

Loading