Remove device_profile #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-kim
force-pushed
the
remove-device-profile
branch
from
4d83d96 to
aaf315e
Compare
|
Have you test the behavior on each device? or Do you need help testing on each device? |
|
@bbrto21 No, I haven't. I'm out of the office until tomorrow. I'll be grateful if you run the test for me (if you think this change is reasonable). |
|
I've test this on wearable, tv, mobile device. it works properly! |
bbrto21
reviewed
Jun 30, 2021
swift-kim
added a commit
that referenced
this pull request
Sep 27, 2021
* Remove device_profile * Remove flutter:: from key_event_channel.cc * Remove system_info dependency
swift-kim
added a commit
that referenced
this pull request
Nov 14, 2021
* Remove device_profile * Remove flutter:: from key_event_channel.cc * Remove system_info dependency
swift-kim
added a commit
that referenced
this pull request
Dec 9, 2021
* Remove device_profile * Remove flutter:: from key_event_channel.cc * Remove system_info dependency
swift-kim
added a commit
that referenced
this pull request
Dec 17, 2021
* Remove device_profile * Remove flutter:: from key_event_channel.cc * Remove system_info dependency
swift-kim
added a commit
that referenced
this pull request
Feb 7, 2022
* Remove device_profile * Remove flutter:: from key_event_channel.cc * Remove system_info dependency
swift-kim
added a commit
that referenced
this pull request
Feb 11, 2022
* Remove device_profile * Remove flutter:: from key_event_channel.cc * Remove system_info dependency
swift-kim
added a commit
that referenced
this pull request
May 12, 2022
* Remove device_profile * Remove flutter:: from key_event_channel.cc * Remove system_info dependency
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
* Remove device_profile * Remove flutter:: from key_event_channel.cc * Remove system_info dependency
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
* Remove device_profile * Remove flutter:: from key_event_channel.cc * Remove system_info dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unnecessary to read the current device profile at runtime.
The use of preprocessor macro is discouraged by the Google style guide, so it's
rather than