Skip to content

Implement TizenRendererEvasGL::SetGeometry #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 9, 2021
Merged

Implement TizenRendererEvasGL::SetGeometry #214

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
29dbf79
Enable window channel on evas gl renderer
bbrto21 Dec 2, 2021
473df21
Fix x64 shell build break
bbrto21 Dec 2, 2021
59b341c
Comment out elm_win_aux_hint_add related stuff
bbrto21 Dec 2, 2021
f0b7ed1
Disable setWindowGeometry on evas gl
bbrto21 Dec 2, 2021
b10a546
Cleanup minor things
bbrto21 Dec 2, 2021
da11e09
Apply suggested changes
bbrto21 Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion shell/platform/tizen/tizen_renderer_evas_gl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,11 @@ Evas_Object* TizenRendererEvasGL::SetupEvasWindow(int32_t* width,
efl_util_set_notification_window_level(evas_window_,
EFL_UTIL_NOTIFICATION_LEVEL_TOP);
}
// Please uncomment below and enable setWindowGeometry of window channel when
// Tizen 5.5 or later was chosen as default.
// elm_win_aux_hint_add(evas_window_, "wm.policy.win.user.geometry", "1");
Copy link
Member

@bwikbs bwikbs Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only necessary for 5.5 and higher? I thought it was absolutely necessary

Copy link
Author

@bbrto21 bbrto21 Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elm_win_aux_hint_add is supported in Tizen 5.5 and later and Our symbol checker filters elm_win_aux_hint_add in Tizen 4.0.

So @swift-kim and I decided to comment it out and to keep that setWindowGeometry disabled on evas gl until Tizen 5.5 or later becomes our default.

Copy link

@HakkyuKim HakkyuKim Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So elm_win_aux_hint_add(evas_window_, "wm.policy.win.user.geometry", "1") is required to configure window size?

Copy link
Author

@bbrto21 bbrto21 Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HakkyuKim Yes, sorry for the late reply, I was on vacation.

#endif

auto* ecore_evas =
ecore_evas_ecore_evas_get(evas_object_evas_get(evas_window_));

Expand Down Expand Up @@ -743,7 +747,23 @@ void TizenRendererEvasGL::SetGeometry(int32_t x,
int32_t y,
int32_t width,
int32_t height) {
FT_UNIMPLEMENTED();
evas_object_move(evas_window_, x, y);
evas_object_resize(evas_window_, width, height);

evas_object_resize(graphics_adapter_, width, height);
evas_object_image_native_surface_set(graphics_adapter_, nullptr);

evas_gl_surface_destroy(evas_gl_, gl_surface_);
evas_gl_surface_destroy(evas_gl_, gl_resource_surface_);

evas_object_image_size_set(graphics_adapter_, width, height);
gl_surface_ = evas_gl_surface_create(evas_gl_, gl_config_, width, height);
gl_resource_surface_ = evas_gl_pbuffer_surface_create(evas_gl_, gl_config_,
Copy link
Member

@bwikbs bwikbs Dec 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried without this? Because the last time I saw it, it didn't seem to be used much.

Copy link
Author

@bbrto21 bbrto21 Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it didn't work without this.

Copy link
Member

@bwikbs bwikbs Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a sample to test this PR?

Copy link
Author

@bbrto21 bbrto21 Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see original PR : #201 (comment)

width, height, nullptr);

Evas_Native_Surface native_surface;
evas_gl_native_surface_get(evas_gl_, gl_surface_, &native_surface);
evas_object_image_native_surface_set(graphics_adapter_, &native_surface);
}

void TizenRendererEvasGL::ResizeWithRotation(int32_t x,
Expand Down