Remove FlutterWindowProperties and get the screen size automatically #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The screen width/height/dpi values returned by the system_info API are just pre-defined values and do not represent the actual properties of the display. The correct values can be only obtained after ecore_wl2_display is created.
swift-kim
changed the base branch from
embedders-for-profiles
to
flutter-2.0.1-tizen
swift-kim
added a commit
that referenced
this pull request
Jun 7, 2021
…72) The screen width/height/dpi values returned by the system_info API are just pre-defined values and do not represent the actual properties of the display. The correct values can be only obtained after ecore_wl2_display is created.
swift-kim
added a commit
that referenced
this pull request
Sep 27, 2021
…72) The screen width/height/dpi values returned by the system_info API are just pre-defined values and do not represent the actual properties of the display. The correct values can be only obtained after ecore_wl2_display is created.
swift-kim
added a commit
that referenced
this pull request
Nov 14, 2021
…72) The screen width/height/dpi values returned by the system_info API are just pre-defined values and do not represent the actual properties of the display. The correct values can be only obtained after ecore_wl2_display is created.
swift-kim
added a commit
that referenced
this pull request
Dec 9, 2021
…72) The screen width/height/dpi values returned by the system_info API are just pre-defined values and do not represent the actual properties of the display. The correct values can be only obtained after ecore_wl2_display is created.
swift-kim
added a commit
that referenced
this pull request
Dec 17, 2021
…72) The screen width/height/dpi values returned by the system_info API are just pre-defined values and do not represent the actual properties of the display. The correct values can be only obtained after ecore_wl2_display is created.
swift-kim
added a commit
that referenced
this pull request
Feb 7, 2022
…72) The screen width/height/dpi values returned by the system_info API are just pre-defined values and do not represent the actual properties of the display. The correct values can be only obtained after ecore_wl2_display is created.
swift-kim
added a commit
that referenced
this pull request
Feb 11, 2022
…72) The screen width/height/dpi values returned by the system_info API are just pre-defined values and do not represent the actual properties of the display. The correct values can be only obtained after ecore_wl2_display is created.
swift-kim
added a commit
that referenced
this pull request
May 12, 2022
…72) The screen width/height/dpi values returned by the system_info API are just pre-defined values and do not represent the actual properties of the display. The correct values can be only obtained after ecore_wl2_display is created.
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
…72) The screen width/height/dpi values returned by the system_info API are just pre-defined values and do not represent the actual properties of the display. The correct values can be only obtained after ecore_wl2_display is created.
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Otherwise, depending on Impeller will cause an explicit dependency on whatever VM variant :libdart picks. And, some other unit-test in the engine explicitly link in the JIT variant which leads to duplicate symbol errors in profile and release modes.
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
…72) The screen width/height/dpi values returned by the system_info API are just pre-defined values and do not represent the actual properties of the display. The correct values can be only obtained after ecore_wl2_display is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The screen width/height/dpi values returned by the system_info API
are just pre-defined values and do not represent the actual
properties of the display. The correct values can be only obtained
after ecore_wl2_display is created.
Fixes flutter-tizen/flutter-tizen#83 (screen size issue).
The target branch of this PR should be changed after #67 is merged.