Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve freetype symbols locally #85

Merged
merged 3 commits into from
May 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ vars = {
'chromium_git': 'https://chromium.googlesource.com',
'swiftshader_git': 'https://swiftshader.googlesource.com',
'dart_git': 'https://dart.googlesource.com',
'flutter_git': 'https://flutter.googlesource.com',
'fuchsia_git': 'https://fuchsia.googlesource.com',
'github_git': 'https://github.com',
'skia_git': 'https://skia.googlesource.com',
Expand Down Expand Up @@ -92,6 +93,7 @@ gclient_gn_args = [
# If you need to add a new host, contact chrome infrastructure team.
allowed_hosts = [
'chromium.googlesource.com',
'flutter.googlesource.com',
'fuchsia.googlesource.com',
'github.com',
'skia.googlesource.com',
Expand Down Expand Up @@ -350,7 +352,7 @@ deps = {
Var('chromium_git') + '/external/colorama.git' + '@' + '799604a1041e9b3bc5d2789ecbd7e8db2e18e6b8',

'src/third_party/freetype2':
Var('fuchsia_git') + '/third_party/freetype2' + '@' + 'edab12c07ac05d1185616688f338b1ad15936796',
Var('flutter_git') + '/third_party/freetype2' + '@' + '1f03c1b2d7f2ae832a4fbe9d12bd96c3c15bbece',

'src/third_party/root_certificates':
Var('dart_git') + '/root_certificates.git' + '@' + Var('dart_root_certificates_rev'),
Expand Down
71 changes: 21 additions & 50 deletions ci/licenses_golden/licenses_third_party

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ci/licenses_golden/tool_signature
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Signature: 164585dad7317491c0f98b96519f87c7
Signature: b8646e680ea27ee6e0e97676ebbe5975

3 changes: 3 additions & 0 deletions shell/platform/embedder/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,9 @@ shared_library("flutter_engine_library") {

output_name = "flutter_engine"

# For Tizen 5.5 or older. See the script file for details.
ldflags = [ "-Wl,--version-script=" + rebase_path("flutter_engine_exports.lst") ]

if (is_mac && !embedder_for_target) {
ldflags = [ "-Wl,-install_name,@rpath/FlutterEmbedder.framework/$_framework_binary_subpath" ]
}
Expand Down
14 changes: 14 additions & 0 deletions shell/platform/embedder/flutter_engine_exports.lst
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Copyright 2021 Samsung Electronics Co., Ltd. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

# Linker script that hides symbols with the prefix "FT_" so that global freetype
# symbols referenced by Skia are not overriden by an external shared library at
# runtime.

{
global:
*;
local:
FT_*;
bbrto21 marked this conversation as resolved.
Show resolved Hide resolved
};
8 changes: 1 addition & 7 deletions shell/platform/tizen/config.gni
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@
# found in the LICENSE file.

declare_args() {
# Whether to build the Tizen shell for the host platform, if available.
#
# By default, the Tizen shell is not built if there is a native toolkit shell,
# but it can be enabled for supported platforms (Linux)
# as an extra build artifact with this flag. The native toolkit shell will
# still be built as well.
# Whether to build the Tizen shell.
build_tizen_shell = false
tizen_sdk_4 = false
}
1 change: 1 addition & 0 deletions tools/licenses/lib/patterns.dart
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ final List<RegExp> copyrightStatementPatterns = <RegExp>[
RegExp(r'^ *For more info read ([^ ]+)$', caseSensitive: false),
RegExp(r'^(?:Google )?Author\(?s?\)?: .+', caseSensitive: false),
RegExp(r'^Written by .+', caseSensitive: false),
RegExp(r'^Originally written by .+', caseSensitive: false),
RegExp(r'^Based on$', caseSensitive: false),
RegExp(r"^based on (?:code in )?['`][^'`]+['`]$", caseSensitive: false),
RegExp(r'^Based on .+, written by .+, [0-9]+\.$', caseSensitive: false),
Expand Down