Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve freetype symbols locally #85

Merged
merged 3 commits into from
May 13, 2021
Merged

Resolve freetype symbols locally #85

merged 3 commits into from
May 13, 2021

Conversation

swift-kim
Copy link
Member

  • Reland "Roll FreeType to 2.10.4" (reverts Revert "Roll FreeType to 2.10.4 (#23666) (#23887)" #60).
  • Provide a version script to the linker to restrict the symbol resolution range. The dynamic linker by default starts to resolve global symbols from loaded shared libraries, not within the current shared library. This results in a reference to undefined symbols on Tizen 5.5 or older devices which load their own version of freetype library onto memory prior to app launch.

Fixes #58.

@swift-kim swift-kim requested a review from a team May 11, 2021 07:09
@swift-kim swift-kim mentioned this pull request May 11, 2021
Closed
@swift-kim swift-kim changed the title Resolve freetype symbols within the engine binary Resolve freetype symbols locally May 12, 2021
bbrto21
bbrto21 approved these changes May 12, 2021
View reviewed changes
Copy link

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbrto21 bbrto21 merged commit 18e31c8 into flutter-tizen:flutter-2.0.1-tizen May 13, 2021
@bwikbs bwikbs mentioned this pull request May 13, 2021
Closed
@swift-kim swift-kim mentioned this pull request Jun 2, 2021
Closed
swift-kim added a commit that referenced this pull request Jun 7, 2021
@swift-kim
Resolve freetype symbols locally (#85)
67e2c79 
* Revert "Revert "Roll FreeType to 2.10.4 (flutter#23666) (flutter#23887)" (#60)"

This reverts commit 582f6fe.

* Resolve freetype symbols within the engine binary

* Clean up unused build flag
swift-kim added a commit that referenced this pull request Sep 27, 2021
@swift-kim
Resolve freetype symbols locally (#85)
3cadd3a 
* Revert "Revert "Roll FreeType to 2.10.4 (flutter#23666) (flutter#23887)" (#60)"

This reverts commit 582f6fe.

* Resolve freetype symbols within the engine binary

* Clean up unused build flag
swift-kim added a commit that referenced this pull request Nov 14, 2021
@swift-kim
Resolve freetype symbols locally (#85)
2b4d44a 
* Revert "Revert "Roll FreeType to 2.10.4 (flutter#23666) (flutter#23887)" (#60)"

This reverts commit 582f6fe.

* Resolve freetype symbols within the engine binary

* Clean up unused build flag
swift-kim added a commit that referenced this pull request Dec 9, 2021
@swift-kim
Resolve freetype symbols locally (#85)
2c6e7ce 
* Revert "Revert "Roll FreeType to 2.10.4 (flutter#23666) (flutter#23887)" (#60)"

This reverts commit 582f6fe.

* Resolve freetype symbols within the engine binary

* Clean up unused build flag
swift-kim added a commit that referenced this pull request Dec 17, 2021
@swift-kim
Resolve freetype symbols locally (#85)
b2094db 
* Revert "Revert "Roll FreeType to 2.10.4 (flutter#23666) (flutter#23887)" (#60)"

* Resolve freetype symbols within the engine binary

* Clean up unused build flag
swift-kim added a commit that referenced this pull request Feb 7, 2022
@swift-kim
Resolve freetype symbols locally (#85)
11c45f3 
* Revert "Revert "Roll FreeType to 2.10.4 (flutter#23666) (flutter#23887)" (#60)"

* Resolve freetype symbols within the engine binary

* Clean up unused build flag
swift-kim added a commit that referenced this pull request Feb 11, 2022
@swift-kim
Resolve freetype symbols locally (#85)
016bb1f 
* Revert "Revert "Roll FreeType to 2.10.4 (flutter#23666) (flutter#23887)" (#60)"

* Resolve freetype symbols within the engine binary

* Clean up unused build flag
swift-kim added a commit that referenced this pull request May 12, 2022
@swift-kim
Resolve freetype symbols locally (#85)
41bfc9a 
* Revert "Revert "Roll FreeType to 2.10.4 (flutter#23666) (flutter#23887)" (#60)"

* Resolve freetype symbols within the engine binary

* Clean up unused build flag
swift-kim added a commit that referenced this pull request Aug 5, 2022
@swift-kim
Resolve freetype symbols locally (#85)
1bd477d 
* Resolve freetype symbols within the engine binary

* Clean up unused build flag
swift-kim added a commit that referenced this pull request Sep 1, 2022
@swift-kim
Resolve freetype symbols locally (#85)
65ed0de 
* Resolve freetype symbols within the engine binary

* Clean up unused build flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrto21 bbrto21 bbrto21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tizen 5.5 watch] Apps cannot launch in candidate mode
2 participants
@swift-kim @bbrto21