Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version-script #87

Closed

Conversation

bwikbs
Copy link
Member

@bwikbs bwikbs commented May 13, 2021

Related PR :#85

Minor changes to achieve the below:

{
  global:
    FlutterDesktop*;
  local:
    *;
}

* Change default visibilty to local

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bwikbs bwikbs requested review from bbrto21 and swift-kim May 13, 2021 07:21
@bwikbs
Copy link
Member Author

bwikbs commented May 13, 2021

It's tested on webview example at FHUB

@swift-kim
Copy link
Member

Minor changes to achieve the below:

I was talking about the embedder binary (libflutter_tizen.so) when I left that comment. I guess FlutterDesktop*; is not necessary for the engine binary.

@swift-kim
Copy link
Member

May I ask any reason for this change?

@bwikbs
Copy link
Member Author

bwikbs commented May 13, 2021

May I ask any reason for this change?

Basically, main purpose of this is to prevent unnecessary symbols to show outside.(like FT?)
It's not essential but someone's favorite part 😄

Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'm against this change because it makes another non-trivial diff between the upstream engine and our engine, and can potentially cause symbol resolution failures.

FlutterDesktop*;
FlutterEngine*;
FlutterPlatformMessage*;
*Dart*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you get this list?

Also you need to update my comment in line 5 to reflect this change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you get this list?

I added it after seeing the error message during build & running.

@bwikbs
Copy link
Member Author

bwikbs commented May 13, 2021

Actually I'm against this change because it makes another non-trivial diff between the upstream engine and our engine, and can potentially cause symbol resolution failures.

Hmm... I'm hard to understand .. I don’t think it’s an important issue that needs discussion.
I'll listen to other's opinion for 1~2 day and withdraw this PR if there is nothing else.

@bwikbs bwikbs closed this May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants