Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Flutter 3.13 analyze issues #612

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Resolve Flutter 3.13 analyze issues #612

merged 2 commits into from
Aug 31, 2023

Conversation

swift-kim
Copy link
Member

Resolves #609.

@swift-kim swift-kim requested review from JSUYA and Swanseo0 August 28, 2023 06:23
@JSUYA
Copy link
Member

JSUYA commented Aug 28, 2023

#611, #613, and #614 contain this change. I recommend each plugin update.

@swift-kim
Copy link
Member Author

This is the recommended way as the CI down time can be minimized (I spent 10 minutes to make this update) and also you will see less ❌ marks in https://github.com/flutter-tizen/plugins/commits/master (3 separate commits vs. single commit).

@JSUYA
Copy link
Member

JSUYA commented Aug 28, 2023

I reviewed the 3 PRs above, at least they look good to me. Would you like to review it together?

JSUYA
JSUYA approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@JSUYA JSUYA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
#611, #613, and #614 will rabase this patch.

@JSUYA JSUYA merged commit 05918a7 into flutter-tizen:master Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSUYA JSUYA JSUYA approved these changes

@Swanseo0 Swanseo0 Awaiting requested review from Swanseo0

Assignees
No one assigned
Labels
p: audioplayers p: flutter_secure_storage p: sqflite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dart analyze error (dart 3.1.0)
2 participants
@swift-kim @JSUYA