Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sqflite] Update sqflite to 2.3.0 #614

Merged
merged 11 commits into from
Sep 6, 2023
Merged

[sqflite] Update sqflite to 2.3.0 #614

merged 11 commits into from
Sep 6, 2023

Conversation

Swanseo0
Copy link
Contributor

  • Update sqflite to 2.3.0
  • Increase the minimum Flutter version to 3.3.
  • Increase the minimum sdk version to 3.0.0.

Related to #609

@JSUYA JSUYA mentioned this pull request Aug 28, 2023
Merged
JSUYA
JSUYA approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

swift-kim
swift-kim reviewed Aug 28, 2023
View reviewed changes
packages/sqflite/analysis_options.yaml Outdated Show resolved Hide resolved
packages/sqflite/CHANGELOG.md Outdated Show resolved Hide resolved
packages/sqflite/CHANGELOG.md Outdated Show resolved Hide resolved
JSUYA
JSUYA reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the changes to packages/sqflite/example/lib/batch_test_page.dart?

Some code differs from frontend plugin. (var -> final)
Is it because of the analyzer's strict-inference option?

@Swanseo0
Copy link
Contributor Author

Swanseo0 commented Sep 1, 2023

Can you explain the changes to packages/sqflite/example/lib/batch_test_page.dart?
Some code differs from frontend plugin. (var -> final)
Is it because of the analyzer's strict-inference option?

@JSUYA Because of the analyzer's prefer_final_locals.
https://github.com/tekartik/sqflite/blob/0cda463f3fb39c73ad947ed37a45f9c783b2a179/sqflite/analysis_options.yaml#L99

@JSUYA
Copy link
Member

JSUYA commented Sep 1, 2023

Can you explain the changes to packages/sqflite/example/lib/batch_test_page.dart?
Some code differs from frontend plugin. (var -> final)
Is it because of the analyzer's strict-inference option?

@JSUYA Because of the analyzer's prefer_final_locals. https://github.com/tekartik/sqflite/blob/0cda463f3fb39c73ad947ed37a45f9c783b2a179/sqflite/analysis_options.yaml#L99

Thank you for reply. First of all, we don't have this analysis_option.yaml in our example path.
Please add this file and check again.

@JSUYA JSUYA merged commit 8ed18ee into flutter-tizen:master Sep 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swift-kim swift-kim swift-kim approved these changes

@JSUYA JSUYA JSUYA approved these changes

Assignees
No one assigned
Labels
p: sqflite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Swanseo0 @JSUYA @swift-kim